fix: add border to the selected state in borderless design and fix outline-offset issue in IE11 #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InnaAtanasova
added
A11y
InnaAtanasova
requested review from
mikerodonnell89,
droshev,
rengare,
salarenko,
JKMarkowski,
stefanoScalzo and
estelaxu3
InnaAtanasova
changed the title
|
Deploy preview for fundamental-styles ready! Built with commit 5646fbd |
InnaAtanasova
added
0.8.0
and removed
A11y
JKMarkowski
approved these changes
Mar 31, 2020
Comment on lines
+14
to
+30
| @mixin fake-list-outline($outlineColor: var(--sapContent_FocusColor)) { | ||
| &:focus, | ||
| &.is-focus { | ||
| outline: none; | ||
|
|
||
| &::before { | ||
| content: ''; | ||
| position: absolute; | ||
| display: block; | ||
| border: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) $outlineColor; | ||
| top: 0.1875rem; | ||
| left: 0.1875rem; | ||
| right: 0.1875rem; | ||
| bottom: 0.1875rem; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I like this solution, it can be used always, when there are no pseudo elements.
estelaxu3
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #789
Closes #762
Description
Add border bottom to the selected state in borderless design;
Added
::beforeattribute tofd-list__itemto play the role of an outline since we need an outline offset and this property is not supported in IE11Screenshots
Before:
After: