fix: Sets default portal id via plugin options

SAP-archive · May 19, 2019 · ded20c5 · ded20c5
1 parent 127ba51
commit ded20c5
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/src/components/Popover/Popover.vue b/src/components/Popover/Popover.vue
@@ -1,6 +1,7 @@
 <template>
   <k-pop
     ref="kpop"
+    :portalId="$fdDefaultPortalId"
     :bodyClass="fdBodyClass"
     arrowClass="fd-popover__arrow"
     :placement="placement"

diff --git a/src/docs/pages/__tests__/examples.test.js b/src/docs/pages/__tests__/examples.test.js
@@ -76,9 +76,9 @@ describe("All Examples", () => {
           let html = "";
           // We are not using chai's doesNotThrow-assertion because we want to have the wrapper to get the html
           try {
-            const componentModule = await import(
-              `./../${page.name}/${example}.vue`
-            );
+            const componentModule = await import(`./../${
+              page.name
+            }/${example}.vue`);
             const component =
               componentModule.default != null
                 ? componentModule.default

diff --git a/src/main.js b/src/main.js
@@ -7,6 +7,7 @@ const FD_AUTO_INSTALL_DISABLED_KEY = "__FD_AUTO_INSTALL_DISABLED_KEY__";
 
 const install = (vue, options) => {
   const normalized = normalizedPluginOptions(options);
+  vue.prototype.$fdDefaultPortalId = normalized.defaultPortalId;
   vue.use(Directives, normalized);
   vue.use(FundamentalVuePlugin, normalized);
   if (normalized.log.welcome) {

diff --git a/src/util/PluginOptions.js b/src/util/PluginOptions.js
@@ -1,10 +1,16 @@
 const makeDefaultOptions = () => ({
-  log: { welcome: false, registerComponent: false }
+  log: {
+    welcome: false,
+    registerComponent: false
+  },
+  defaultPortalId: "fd-portal-container"
 });
+
 export const normalizedPluginOptions = (options = makeDefaultOptions()) => {
-  const { log = {} } = options;
+  const { log = {}, defaultPortalId = "fd-portal-container" } = options;
   const defaultLog = makeDefaultOptions().log;
   return {
+    defaultPortalId,
     log: {
       ...defaultLog,
       ...log