Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge detection for popover-style elements #134

Closed
bcullman opened this issue Jan 30, 2019 · 3 comments
Closed

Edge detection for popover-style elements #134

bcullman opened this issue Jan 30, 2019 · 3 comments
Assignees
@suwarnoong
Labels
enhancement New feature or request

Comments

@bcullman
Copy link

bcullman commented Jan 30, 2019 •
edited
Loading

popovers (and other popup style components. should edge-detect and flip where there is no space.

popperjs / popperjs github provides this functionality, and has libraries to react, angular and vue

https://www.npmjs.com/package/react-popper
https://www.npmjs.com/package/ngx-popper
https://www.npmjs.com/package/vue-popperjs

SAP Concur has previously had good success with popper.js, and implemented within our pre-fundamentals components library.

image

also see
SAP/fundamental-ngx#410 and
SAP/fundamental-react#313
This was referenced Jan 30, 2019
Closed
Closed
@ChristianKienle
Copy link
Contributor

This has been implemented in https://github.com/SAP/fundamental-vue/tree/feature/popper.

PR should be created soon.

@ChristianKienle
Copy link
Contributor

@suwarnoong I am assigning this to you if you don't mind since you have done most of the work already. :D

@ChristianKienle ChristianKienle added the enhancement New feature or request label Mar 2, 2019
@suwarnoong suwarnoong mentioned this issue Mar 4, 2019
Closed
@ChristianKienle
Copy link
Contributor

Will be fixed by #291. Merge incoming. Closing already,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suwarnoong suwarnoong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add popper integration SAP/fundamental-vue
3 participants
@ChristianKienle @bcullman @suwarnoong