Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

feat: Popper, Tree Shaking, Modals, … #291

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Conversation

ChristianKienle
Copy link
Contributor

@ChristianKienle ChristianKienle commented Apr 20, 2019

Changes introduced by this PR 👯‍♂️

  • Typescript is no longer used to build our stuff.
    • Tests execute approx. 3 times faster.
    • Building is way faster
    • Overall reduction in code size. Sometimes we had to write code to silence Typescript even though it was not really necessary. Adding // @ts-no-check everywhere would have been possible of course but it just feels strange.
  • A lot of new tests and fixes.
    • I think using just plain Vue-files + JS is also a lot more readable.
  • Improved Project setup: Just one directory. One project: No more yarn bootstrap.
  • Fundamental Vue is now Tree Shakeable 👯‍♂️
  • Popper.js integration and a new Popover-component.
  • Improved Modals
  • MEGA TEST is back. 💃 The test src/docs/pages/__tests__/examples.test.js is back up and works properly. It simply mounts all of our examples and fails if Vue or something else complains while doing so.
  • FdMenuItem is now smart (see documentation for details)
  • NEW component: FdShellBarActionButton: Allows you to add custom icons in the shell bar.
  • Prefixed all directives with fd: v-icon becomes v-fd-icon, …
  • Improved & new Directives:
    • v-fd-icon supports icon sizes: v-fd-icon:settings.xl will yield a big settings icon.
    • v-fd-show-modal (NEW) can be attached to anything that emits click-events. Once attached
      & clicked it caused a modal to appear.
    • v-fd-type allows you to set a type class (-1, 0, 1, … 6): v-fd-type:6 will render text which is very big.
    • v-fd-click-out allows you to do something when a click outside a certain element/component has been detected.

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2019

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Apr 20, 2019

Deploy preview for fundamental-vue ready!

Built with commit 62ac72b

https://deploy-preview-291--fundamental-vue.netlify.com

@ChristianKienle ChristianKienle force-pushed the feat/stuff branch 9 times, most recently from ae88a10 to 4804ef4 Compare April 21, 2019 16:24
@ChristianKienle ChristianKienle force-pushed the feat/stuff branch 5 times, most recently from 3d06d73 to 5531cd0 Compare April 21, 2019 17:20
@ChristianKienle ChristianKienle requested a review from a team April 21, 2019 18:37
@ChristianKienle ChristianKienle changed the title feat: Added new Popover implementation based on Popper.Js feat: Popper, Tree Shaking, Modals, … Apr 21, 2019
@ChristianKienle ChristianKienle marked this pull request as ready for review April 21, 2019 18:38
@ChristianKienle ChristianKienle force-pushed the feat/stuff branch 2 times, most recently from cce11dc to 5eb9900 Compare April 25, 2019 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants