-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy mkdocs when merging to master #106
Conversation
@o-liver You triggered deployment of changes on master branch initially. Some questions:
|
.travis.yml
Outdated
@@ -4,7 +4,16 @@ install: | |||
- pip install --user mkdocs mkdocs-material | |||
script: | |||
- mvn test -B | |||
- if [[ "${TRAVIS_PULL_REQUEST}" != "false" ]]; then cd documentation && mkdocs build --clean --verbose --strict && cd ..; fi; | |||
- | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume this lets you spread the if then else over a few lines. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
.travis.yml
Outdated
else | ||
if [ "${TRAVIS_BRANCH}" == "master" ] | ||
then | ||
gh-pages-deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you don't have to make this file executable before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the file mode for gh-pages-deploy to 755. I gets checked out from git with the executable flag already set.
But I see now something else: should be ./gh-pages-deploy
rather than simply gh-pages-deploy
.
|
d9f9eb1
to
0f81bb0
Compare
Travis build number 491 was fine, but did not report back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Only changes to master and PRs starts the travis job. On PR Maven tests and mkdocs build for warnings and error check is done. On change on master Maven is **not** run and the documentation is built and deployed using a deploy key. The encrypted deploy key is not part of this commit, it needs to be provided by an admin for this repository.
0f81bb0
to
0a58ad6
Compare
Only changes to master and PRs starts the travis job.
On PR Maven tests and mkdocs build for warnings and error check is done.
On change on master Maven is not run and the documentation is built
and deployed using a deploy key. The encrypted deploy key is not part of
this commit, it needs to be provided by an admin for this repository.