Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerExecute: handle stashContent #332

Merged
merged 10 commits into from
Nov 5, 2018
Merged

dockerExecute: handle stashContent #332

merged 10 commits into from
Nov 5, 2018

Conversation

CCFenner
Copy link
Member

@CCFenner CCFenner commented Oct 8, 2018

changes:

  • executeDocker uses stashContent
  • executeDockerOnKubernetes only stashed workspace if stashContent is not set

OliverNocon
OliverNocon approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@OliverNocon OliverNocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OliverNocon
Copy link
Member

@rkamath3 do you want to have another look before merging?

@rkamath3
Copy link
Contributor

rkamath3 commented Nov 1, 2018

@OliverNocon Yes, I will run few tests and approve the PR.

@rkamath3
Copy link
Contributor

rkamath3 commented Nov 4, 2018

LGTM, SDK pipeline tests are successful

@rkamath3 rkamath3 self-requested a review November 4, 2018 12:46
@OliverNocon OliverNocon merged commit aa5ad1c into master Nov 5, 2018
@CCFenner CCFenner deleted the CCFenner/stashing2 branch November 7, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkamath3 rkamath3 rkamath3 approved these changes

@OliverNocon OliverNocon OliverNocon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CCFenner @OliverNocon @rkamath3