Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new step karmaExecuteTests #351

Merged
merged 21 commits into from
Nov 8, 2018
Merged

add new step karmaExecuteTests #351

merged 21 commits into from
Nov 8, 2018

Conversation

CCFenner
Copy link
Member

@CCFenner CCFenner commented Oct 19, 2018

changes:

  • add new step karmaExecuteTests
  • add tests
  • add documentation

@CCFenner CCFenner closed this Oct 22, 2018
@CCFenner CCFenner reopened this Oct 23, 2018
@CCFenner
Copy link
Member Author

real world tests on k8s successful

@CCFenner CCFenner changed the title add new step qunitExecuteTests add new step karmaExecuteTests Oct 23, 2018
@CCFenner
Copy link
Member Author

real world test with native docker successful

@CCFenner
Copy link
Member Author

CCFenner commented Oct 23, 2018

requires #352 >> merged

@CCFenner CCFenner added the ON HOLD Issue / PR is blocked label Oct 23, 2018
@CCFenner CCFenner removed the ON HOLD Issue / PR is blocked label Oct 24, 2018
Copy link
Member

@OliverNocon OliverNocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Documentation to be finalized though ...

@CCFenner CCFenner added the REVIEW Pull-Request needs a review label Oct 28, 2018
Copy link
Member

@OliverNocon OliverNocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have another look at the documentation

documentation/docs/steps/karmaExecuteTests.md Outdated Show resolved Hide resolved
documentation/docs/steps/karmaExecuteTests.md Outdated Show resolved Hide resolved
documentation/docs/steps/karmaExecuteTests.md Outdated Show resolved Hide resolved
documentation/docs/steps/karmaExecuteTests.md Outdated Show resolved Hide resolved
documentation/docs/steps/karmaExecuteTests.md Outdated Show resolved Hide resolved
documentation/docs/steps/karmaExecuteTests.md Outdated Show resolved Hide resolved

In this step the ([Karma test runner](http://karma-runner.github.io)) is executed.

The step is using the `seleniumExecuteTest` step to spins up two containers in a Docker network:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length

## Prerequisites

- **running Karma tests** - have a NPM module with running tests executed with Karma
- **configured WebDriver** - have the [`karma-webdriver-launcher`](https://github.com/karma-runner/karma-webdriver-launcher) package installed and a custom, WebDriver-based browser configured in Karma
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length

|sidecarVolumeBind|no|||
|stashContent|no|||

- `script` - defines the global script environment of the Jenkinsfile run. Typically `this` is passed to this parameter. This allows the function to access the [`commonPipelineEnvironment`](commonPipelineEnvironment.md) for storing the measured duration.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length

documentation/docs/steps/karmaExecuteTests.md Outdated Show resolved Hide resolved
documentation/docs/steps/karmaExecuteTests.md Outdated Show resolved Hide resolved
- a Selenium/Chrome container (`selenium/standalone-chrome`)
- a NodeJS container (`node:8-stretch`)

In the Docker network, the containers can be referenced by the values provided in `dockerName` and `sidecarName`, the default values are `karma` and `selenium`. These values must be used in the `hostname` properties of the test configuration ([Karma](https://karma-runner.github.io/1.0/config/configuration-file.html) and [WebDriver](https://github.com/karma-runner/karma-webdriver-launcher#usage)).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length

vars/karmaExecuteTests.groovy Outdated Show resolved Hide resolved
vars/karmaExecuteTests.groovy Show resolved Hide resolved
vars/karmaExecuteTests.groovy Outdated Show resolved Hide resolved
@CCFenner CCFenner self-assigned this Nov 7, 2018
@CCFenner CCFenner merged commit 9a1ab37 into master Nov 8, 2018
@CCFenner CCFenner deleted the CCFenner/qunit branch November 8, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REVIEW Pull-Request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants