[FIX] HTML mode: QUnit.config.noglobals with coverage enabled #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code instrumented by istanbul introduces global variables (cov_* for each file and a global __coverage__ variable). This causes a failure when the "noglobals" QUnit config is active and some file is loaded during a test as this pollutes the global namespace. Hooking into the "after" function allows to add those variables to the list of known globals so that they won't be detected as new globals.
codeworrior
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
LGTM. It took me a while to understand, how the test works:
- it wasn't obvious to me that coverage is active in the test
- it wasn't obvious to me whether test/app/foo will be instrumented or not
(because the 'test' folder is excluded from instrumentation - one has to know the difference
between folder names and module IDs and how both are used in the app)
Well, but the test covers what has been changed, so it's okay.
|
|
||
| QUnit.start(); | ||
| QUnit.test("Karma", function(assert) { | ||
| assert.ok(parent.__karma__.files["/base/webapp/.dotfile"], "Karma files should contain dotfiles"); |
There was a problem hiding this comment.
How is this related to the change?
There was a problem hiding this comment.
It's not. The test has been there before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code instrumented by istanbul introduces global variables
(cov_* for each file and a global
__coverage__variable).This causes a failure when the "noglobals" QUnit config is active and
some file is loaded during a test as this pollutes the global namespace.
Hooking into the "after" function allows to add those variables to the
list of known globals so that they won't be detected as new globals.