Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] HTML mode: QUnit.config.noglobals with coverage enabled #223

Merged
merged 2 commits into from
Aug 24, 2020
Merged

[FIX] HTML mode: QUnit.config.noglobals with coverage enabled #223

merged 2 commits into from
Aug 24, 2020

Commits on Aug 20, 2020

  1. [FIX] HTML mode: QUnit.config.noglobals with coverage enabled 

    Code instrumented by istanbul introduces global variables
(cov_* for each file and a global __coverage__ variable).
This causes a failure when the "noglobals" QUnit config is active and
some file is loaded during a test as this pollutes the global namespace.

Hooking into the "after" function allows to add those variables to the
list of known globals so that they won't be detected as new globals.
    @matz3
    matz3 committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    e494d2d View commit details
    Browse the repository at this point in the history

  2. [INTERNAL] Fix IE11

    @matz3
    matz3 committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    63c7375 View commit details
    Browse the repository at this point in the history