Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Karma-UI5 should respect configPath for autoDetectType #595

Closed
petermuessig opened this issue Aug 11, 2023 · 2 comments · Fixed by #617
Closed

Karma-UI5 should respect configPath for autoDetectType #595

petermuessig opened this issue Aug 11, 2023 · 2 comments · Fixed by #617
Assignees
@d3xter666
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@petermuessig
Copy link

In the function autoDetectType we hard-coded the ui5.yaml but we could also consider to use the configPath instead, right?

https://github.com/SAP/karma-ui5/blob/main/lib/framework.js#L305
@matz3 matz3 added the bug Something isn't working label Aug 15, 2023
@matz3
Copy link
Member

matz3 commented Aug 15, 2023

True. This is a bug and should be fixed. configPath should be considered.

@matz3 matz3 added the good first issue Good for newcomers label Aug 15, 2023
@d3xter666 d3xter666 mentioned this issue Oct 12, 2023
Merged
@d3xter666 d3xter666 self-assigned this Oct 12, 2023
d3xter666 added a commit that referenced this issue Oct 17, 2023
@d3xter666
[FIX] Consider configPath when autoDetectType (#617)
92847bd 
fixes: #595
@petermuessig
Copy link
Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d3xter666 d3xter666

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Consider configPath when autoDetectType SAP/karma-ui5
3 participants
@matz3 @petermuessig @d3xter666