Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Consider configPath when autoDetectType #617

Merged
merged 3 commits into from
Oct 17, 2023
Merged

[FIX] Consider configPath when autoDetectType #617

merged 3 commits into from
Oct 17, 2023

Conversation

d3xter666
Copy link
Contributor

fixes: #595

@d3xter666 d3xter666 requested review from a team and petermuessig October 12, 2023 12:19
@coveralls
Copy link

coveralls commented Oct 12, 2023 •
edited
Loading

Coverage Status

coverage: 55.823% (+0.1%) from 55.69% when pulling bbc8a04 on ui5-configPath into d10a950 on main.

matz3
matz3 previously requested changes Oct 12, 2023
View reviewed changes
lib/framework.js Outdated Show resolved Hide resolved
@matz3 matz3 added the bug Something isn't working label Oct 12, 2023
@d3xter666 d3xter666 requested a review from matz3 October 16, 2023 07:30
@d3xter666 d3xter666 dismissed matz3’s stale review October 17, 2023 10:57

Issues were addressed and got approval

@d3xter666 d3xter666 merged commit 92847bd into main Oct 17, 2023
19 checks passed
@d3xter666 d3xter666 deleted the ui5-configPath branch October 17, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte approved these changes

@petermuessig petermuessig Awaiting requested review from petermuessig

@matz3 matz3 Awaiting requested review from matz3

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Karma-UI5 should respect configPath for autoDetectType
4 participants
@d3xter666 @coveralls @matz3 @RandomByte