[FIX] Improve library request handling #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
commented
Oct 1, 2020
| @@ -7,8 +7,7 @@ async function init(config, logger) { | |||
| await framework.init({config, logger}); | |||
There was a problem hiding this comment.
This already ensures that the plugin setup (incl. async tooling setup) is done before requests come in...
| @@ -17,13 +16,6 @@ init.$inject = ["config", "logger"]; | |||
|
|
|||
| module.exports = { | |||
| "framework:ui5": ["factory", init], | |||
| "middleware:ui5--pauseRequests": ["factory", function() { | |||
There was a problem hiding this comment.
... therefore pausing requests is not required anymore
RandomByte
requested changes
Oct 6, 2020
| next(); | ||
| } | ||
| }; | ||
| rewriteUrlBefore(url) { |
There was a problem hiding this comment.
It would be great to have a comment for this and rewriteUrl explaining their purpose
RandomByte
approved these changes
Oct 6, 2020
matz3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.