Fix inline theme parameters encoding for '#' #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A '#' character marks the start of the URI fragment component and needs to be escaped to be part of the body. Currently, this still works without encoding, but browsers might change this in future. See: https://www.chromestatus.com/features/5656049583390720
|
I just noticed that this currently breaks the runtime as the encoded # sign won't be decoded. I will follow-up on this. |
openui5bot
pushed a commit
to SAP/openui5
that referenced
this pull request
Jun 27, 2018
See: SAP/less-openui5#23 Change-Id: I40644af9417128fbba940b874f0e5572067647ab
openui5bot
pushed a commit
to SAP/openui5
that referenced
this pull request
Jul 5, 2018
See: SAP/less-openui5#23 BCP: 1880276569 CR-Id: 002075125900002498432018 Change-Id: I40644af9417128fbba940b874f0e5572067647ab (cherry picked from commit ca3b448)
openui5bot
pushed a commit
to SAP/openui5
that referenced
this pull request
Jul 5, 2018
See: SAP/less-openui5#23 BCP: 1880276569 CR-Id: 002075125900002498442018 Change-Id: I40644af9417128fbba940b874f0e5572067647ab (cherry picked from commit ca3b448)
openui5bot
pushed a commit
to SAP/openui5
that referenced
this pull request
Jul 5, 2018
See: SAP/less-openui5#23 BCP: 1880276569 CR-Id: 002075125900002498452018 Change-Id: I40644af9417128fbba940b874f0e5572067647ab (cherry picked from commit ca3b448)
openui5bot
pushed a commit
to SAP/openui5
that referenced
this pull request
Jul 5, 2018
See: SAP/less-openui5#23 BCP: 1880276569 CR-Id: 002075125900002498462018 Change-Id: I40644af9417128fbba940b874f0e5572067647ab (cherry picked from commit ca3b448)
openui5bot
pushed a commit
to SAP/openui5
that referenced
this pull request
Jul 5, 2018
See: SAP/less-openui5#23 BCP: 1880276569 CR-Id: 002075125900002498472018 Change-Id: I40644af9417128fbba940b874f0e5572067647ab (cherry picked from commit ca3b448)
matz3
added a commit
that referenced
this pull request
Sep 10, 2018
Proper encoding fix. See #23, #26. A '#' character marks the start of the URI fragment component and needs to be escaped to be part of the body. Currently, this still works without encoding, but browsers might change this in future. See: https://www.chromestatus.com/features/5656049583390720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A '#' character marks the start of the URI fragment component and needs
to be escaped to be part of the body.
Currently, this still works without encoding, but browsers might change
this in future.
See: https://www.chromestatus.com/features/5656049583390720