Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Upgrade devDependencies / Update CI matrix #304

Merged
merged 2 commits into from
Jul 17, 2023
Merged

[INTERNAL] Upgrade devDependencies / Update CI matrix #304

merged 2 commits into from
Jul 17, 2023

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jul 17, 2023

No description provided.

@matz3 matz3 requested a review from a team July 17, 2023 06:30
@matz3
[BREAKING] Require Node.js >= 16.18.0 / npm >= 8
9a29ea3 
BREAKING CHANGE:
Support for older Node.js and npm releases has been dropped.
Only Node.js v16.18.0 and npm v8 or higher are supported.
flovogt
flovogt requested changes Jul 17, 2023
View reviewed changes
Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is a breaking change, isn't? so we will release a new major version=

.npmrc Show resolved Hide resolved
@matz3
Copy link
Member Author

matz3 commented Jul 17, 2023

Yes, it is breaking. As per node-semver, the next version should be 0.12.0. I just wanted to finally upgrade the devDepenencies, but I don't really see a need of releasing a new version immediately as it does not have any impact on the shipped package itself.

@matz3 matz3 merged commit 14b7c20 into master Jul 17, 2023
12 checks passed
@matz3 matz3 deleted the upgrade-dev-dependencies branch July 17, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flovogt flovogt flovogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matz3 @flovogt