Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WC API #1697

Merged
merged 3 commits into from Nov 20, 2020
Merged

Add WC API #1697

merged 3 commits into from Nov 20, 2020

Conversation

ndricimrr
Copy link
Contributor

Description
Resolves #1546

Changes proposed in this pull request:

  • Currently we expose the whole luigi object to the web component, which is then used to call api functions upon. This can result in misuses on the client web-component developers, i.e.: they might override the object, or might use api calls that would not be client but core related.
  • This PR exposes only parts of the core that makes sense in the client perspective, currently its uxManager and linkManager but it can be extended later.
  • You can access client api in this form : this.LuigiClient.uxManager() instead of this.luigi.ux()

@ndricimrr ndricimrr added this to the Sprint 14 milestone Nov 10, 2020
@ndricimrr ndricimrr changed the title Add WC api Add WC API Nov 10, 2020
@ndricimrr ndricimrr added the enhancement New feature or request label Nov 10, 2020
@stanleychh stanleychh self-assigned this Nov 13, 2020
@hardl hardl self-assigned this Nov 16, 2020
hardl
hardl approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@hardl hardl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohannesDoberer JohannesDoberer merged commit fb5e515 into SAP:feature-wc-support Nov 20, 2020
@ndricimrr ndricimrr deleted the wc-client-api branch August 31, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleychh stanleychh stanleychh approved these changes

@hardl hardl hardl approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

Assignees

@stanleychh stanleychh

@hardl hardl

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 14
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ndricimrr @stanleychh @hardl @JohannesDoberer