Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Luigi Context Observable running outside of Angular Zone #2403

Merged
merged 4 commits into from
Dec 9, 2021

Conversation

SomeKay
Copy link
Member

@SomeKay SomeKay commented Nov 26, 2021

Description
Fixes the problems arising from the Context Observable running outside of the Angular Zone.

Related issue(s)
Resolves #2402

@cla-assistant
Copy link

cla-assistant bot commented Nov 26, 2021

CLA assistant check
All committers have signed the CLA.

@ndricimrr ndricimrr added this to the Sprint 22 milestone Nov 30, 2021
@ndricimrr ndricimrr self-assigned this Nov 30, 2021
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested and works as expected 👍

@ndricimrr ndricimrr merged commit d2c2081 into SAP:master Dec 9, 2021
@JohannesDoberer JohannesDoberer added the bug Something isn't working label Dec 23, 2021
@JohannesDoberer JohannesDoberer mentioned this pull request Dec 23, 2021
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LuigiContextService Observable runs outside of Angular Zone
3 participants