Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make User Setting dialog to use compact controls, add user avatar to User Account section #2452

Merged
merged 19 commits into from
Jan 25, 2022

Conversation

UlianaMunich
Copy link
Contributor

@UlianaMunich UlianaMunich commented Dec 21, 2021

Fixes #2419

This PR covers every point which is marked as **+ under the DXP Issue

@JohannesDoberer JohannesDoberer added this to the Sprint 22 milestone Dec 21, 2021
@JohannesDoberer JohannesDoberer added the bug Something isn't working label Dec 21, 2021
@stanleychh stanleychh self-assigned this Jan 4, 2022
Copy link
Contributor

@hardl hardl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AuthLayer must be decoupled from UserSettings

core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
core/src/UserSettingsDialog.html Outdated Show resolved Hide resolved
Copy link
Contributor

@hardl hardl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UlianaMunich UlianaMunich merged commit 0f54f15 into SAP:master Jan 25, 2022
@UlianaMunich UlianaMunich deleted the 2419-user-settings-updatees branch January 25, 2022 13:35
@ndricimrr ndricimrr mentioned this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Settings improvements
5 participants