Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node params works when hashrouting enabled #2490

Merged
merged 11 commits into from
Jan 26, 2022
Merged

Add node params works when hashrouting enabled #2490

merged 11 commits into from
Jan 26, 2022

Conversation

JohannesDoberer
Copy link
Contributor

@JohannesDoberer JohannesDoberer commented Jan 20, 2022 •
edited

Fixes #2484
How to test:

  • Enable hash routing
  • add node params to url using Luigi core api and Luigi client

Expected:
Node params should be added to hash and not before hash (which happens with luigi client => https://fiddle.luigi-project.io/?%7Etest=test#/home/overview)

Follow-up issues

@JohannesDoberer JohannesDoberer added the bug Something isn't working label Jan 20, 2022
@stanleychh stanleychh self-assigned this Jan 21, 2022
@JohannesDoberer JohannesDoberer merged commit b673709 into master Jan 26, 2022
@JohannesDoberer JohannesDoberer deleted the AddNodeParams-works-when-hashrouting-enabled branch January 26, 2022 09:19
@ndricimrr ndricimrr mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleychh stanleychh stanleychh approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@rafalgamon rafalgamon Awaiting requested review from rafalgamon

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

@wdoberschuetz wdoberschuetz Awaiting requested review from wdoberschuetz

Assignees

@stanleychh stanleychh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node params does not work if hash routing is enabled
2 participants
@JohannesDoberer @stanleychh