Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search params are not deleted #2492

Merged
merged 10 commits into from
Feb 3, 2022

Conversation

JohannesDoberer
Copy link
Contributor

@JohannesDoberer JohannesDoberer commented Jan 20, 2022

Fixes #2491
How to test:

  • Please test with useHashrouting = true/false

LuigiClient:

searchParams:
- LuigiClient.addCoreSearchParams({q:'test', luigi:'rocks', tets:'tets'});
- LuigiClient.addCoreSearchParams({q:undefined})
nodeParams:
LuigiClient.addNodeParams({q:'test', luigi:'rocks'});
LuigiClient.addNodeParams({q:undefined, luigi:'rocks'});

Luigi Core

searchParams:
Luigi.routing().addSearchParams({test:'tets'})
Luigi.routing().addSearchParams({test:undefined})

nodeParams:
Luigi.routing().addNodeParams({test:'tets'})
Luigi.routing().addNodeParams({test:undefined})

@JohannesDoberer JohannesDoberer added the bug Something isn't working label Jan 20, 2022
@wdoberschuetz wdoberschuetz self-assigned this Feb 1, 2022
# Conflicts:
#	test/e2e-test-application/e2e/tests/0-fiddle/fiddle-navigation.spec.js
@wdoberschuetz
Copy link
Contributor

LGTM :).

@JohannesDoberer JohannesDoberer changed the title Node and search params are not deleted Search params are not deleted Feb 3, 2022
@JohannesDoberer JohannesDoberer merged commit 9762640 into master Feb 3, 2022
@JohannesDoberer JohannesDoberer deleted the addNodeParams-does-not-delete-properties branch February 3, 2022 11:04
@ndricimrr ndricimrr mentioned this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node and serach params are not deleted
2 participants