Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keepURL in pagenotfoundhandler #2598

Merged
merged 14 commits into from
Mar 10, 2022
Merged

keepURL in pagenotfoundhandler #2598

merged 14 commits into from
Mar 10, 2022

Conversation

hardl
Copy link
Contributor

@hardl hardl commented Feb 28, 2022

Description

With this PR, it will be possible to change main url behaviour in case of pagenotfound error, i.e. one can now define to keep the erroneous url in the browsers address bar (e.g. to correct a typo). An example config would look like this:

...
 routing: {
              useHashRouting: true,
              pageNotFoundHandler: (path, anyMatch) => {
                return {
                  redirectTo: '/error',
                  keepURL: true
                };
              }
          },
...

@hardl
Copy link
Contributor Author

hardl commented Feb 28, 2022

Created as draft, needs test adjustments and docu.

@ndricimrr ndricimrr self-assigned this Feb 28, 2022
@ndricimrr ndricimrr added documentation documentation tasks enhancement New feature or request labels Mar 1, 2022
@ndricimrr ndricimrr marked this pull request as ready for review March 1, 2022 14:13
@ndricimrr ndricimrr modified the milestone: Backlog Mar 1, 2022
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
@stanleychh stanleychh self-assigned this Mar 3, 2022
@ndricimrr ndricimrr merged commit 3038f63 into master Mar 10, 2022
@ndricimrr ndricimrr deleted the pagenotfound-keepurl branch March 10, 2022 21:04
@ndricimrr ndricimrr mentioned this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants