Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix faulty pathExists race condition #2605

Merged
merged 9 commits into from
Mar 14, 2022
Merged

Fix faulty pathExists race condition #2605

merged 9 commits into from
Mar 14, 2022

Conversation

ndricimrr
Copy link
Contributor

@ndricimrr ndricimrr commented Mar 7, 2022 •
edited

Description

Changes proposed in this pull request:

  • Replaces Date.now() with getRandomId() to avoid consecutively run promises having same id, which would then lead into incorrect promise results.

Related issue(s)
Fixes #2592

@ndricimrr ndricimrr added the bug Something isn't working label Mar 7, 2022
@ndricimrr ndricimrr added this to the Sprint 22 milestone Mar 7, 2022
@ndricimrr ndricimrr removed this from the Sprint 22 milestone Mar 7, 2022
@JohannesDoberer JohannesDoberer self-assigned this Mar 7, 2022
JohannesDoberer
JohannesDoberer approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ndricimrr ndricimrr merged commit f091955 into master Mar 14, 2022
@ndricimrr ndricimrr deleted the 2592-path-exists-wrong-result branch March 14, 2022 13:07
@ndricimrr ndricimrr mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@stanleychh stanleychh Awaiting requested review from stanleychh

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

@wdoberschuetz wdoberschuetz Awaiting requested review from wdoberschuetz

@rafalgamon rafalgamon Awaiting requested review from rafalgamon

Assignees

@JohannesDoberer JohannesDoberer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linkManager().pathExists(…) returns wrong results if called multiple times at the same time
2 participants
@ndricimrr @JohannesDoberer