Error handling on productswitcher columns calculation #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesDoberer
requested review from
alexandra-simeonova,
hardl,
ndricimrr,
stanleychh,
UlianaMunich,
wdoberschuetz and
viktorsperling
as code owners
wdoberschuetz
approved these changes
Apr 12, 2022
| @@ -19,8 +19,14 @@ class NavigationHelpersClass { | |||
|
|
|||
| getProductSwitcherColumnsNumber() { | |||
| const productSwitcherConfig = this.getProductSwitcherConfig(); | |||
| if (!productSwitcherConfig.items) return; | |||
There was a problem hiding this comment.
(n2h) Could we get a test case where items undefined or null? :)
| @@ -19,8 +19,14 @@ class NavigationHelpersClass { | |||
|
|
|||
| getProductSwitcherColumnsNumber() { | |||
| const productSwitcherConfig = this.getProductSwitcherConfig(); | |||
| if (!productSwitcherConfig.items) return; | |||
| let productSwitcherColumns = productSwitcherConfig.columns; | |||
There was a problem hiding this comment.
(n2h) This seems to be never reassigned so it could be a const.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2650