-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable keyboard accessibility on confirmation modal background elements #2672
Merged
ndricimrr
merged 17 commits into
master
from
2411-disable-keyboard-on-confirmation-modal
Apr 28, 2022
Merged
Disable keyboard accessibility on confirmation modal background elements #2672
ndricimrr
merged 17 commits into
master
from
2411-disable-keyboard-on-confirmation-modal
Apr 28, 2022
+154
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndricimrr
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
stanleychh,
UlianaMunich,
wdoberschuetz and
viktorsperling
as code owners
April 14, 2022 18:24
wdoberschuetz
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables the keyboard accessibility on all the elements except for the confirmation modal when the latter is opened.
When confirmation modal is closed the keyboard accessibility is reset to default.
Changes proposed in this pull request:
Related issue(s)
Fixes #2411
Possible follow-up: