Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable keyboard accessibility on confirmation modal background elements #2672

Merged
merged 17 commits into from
Apr 28, 2022

Conversation

ndricimrr
Copy link
Contributor

@ndricimrr ndricimrr commented Apr 14, 2022

Description
Disables the keyboard accessibility on all the elements except for the confirmation modal when the latter is opened.
When confirmation modal is closed the keyboard accessibility is reset to default.

Changes proposed in this pull request:

  • Add corresponding enable/disable functions

Related issue(s)
Fixes #2411

Possible follow-up:

  • Backdrop added on Modals & Drawers. Need to disable background keyboard there too.

@ndricimrr ndricimrr added A11Y Accessibility enhancement New feature or request labels Apr 14, 2022
@wdoberschuetz wdoberschuetz self-assigned this Apr 15, 2022
@ndricimrr ndricimrr added the WIP Work in progress label Apr 19, 2022
@ndricimrr ndricimrr removed the WIP Work in progress label Apr 22, 2022
Copy link
Contributor

@wdoberschuetz wdoberschuetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ndricimrr ndricimrr merged commit 46a1532 into master Apr 28, 2022
@ndricimrr ndricimrr deleted the 2411-disable-keyboard-on-confirmation-modal branch April 28, 2022 14:49
@ndricimrr ndricimrr mentioned this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11Y Accessibility enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When confirmation modal is opened, make background elements are not accessible by keyboard
2 participants