Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getNodeParams decoding issue #2686

Merged
merged 11 commits into from
May 2, 2022
Merged

Conversation

ndricimrr
Copy link
Contributor

@ndricimrr ndricimrr commented Apr 27, 2022

Description
Adding node params from the client results in extra sanitisation when special characters are encountered.

Changes proposed in this pull request:

  • de-sanitise back the parameter string upon returning it
  • use getNodeParams(true) to desanitise the parameter value containing special characters

Related issue(s)
Fixes #2673

@wdoberschuetz wdoberschuetz self-assigned this Apr 27, 2022
client/src/helpers.js Show resolved Hide resolved
@UlianaMunich UlianaMunich added the WIP Work in progress label Apr 29, 2022
@ndricimrr ndricimrr removed the WIP Work in progress label Apr 29, 2022
@ndricimrr ndricimrr merged commit e0e7918 into master May 2, 2022
@ndricimrr ndricimrr deleted the 2673-get-node-params-paramEncoding branch May 2, 2022 09:57
@ndricimrr ndricimrr mentioned this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LuigiClient.linkManager().navigate() doesn't send query parameters
3 participants