Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor buildpath for getcurrentpath #2765

Merged
merged 14 commits into from
Jun 28, 2022

Conversation

ndricimrr
Copy link
Contributor

@ndricimrr ndricimrr commented Jun 22, 2022

Description

Changes proposed in this pull request:

  • Refactor accordingly and add support for all other options
  • Fix dynamic path, inconsistency issues with the path received

Related issue(s)

Fixes #2758

@ndricimrr ndricimrr added enhancement New feature or request refactoring Something needs to be refactored in a separate task labels Jun 22, 2022
@ndricimrr ndricimrr added the WIP Work in progress label Jun 23, 2022
@ndricimrr ndricimrr removed the WIP Work in progress label Jun 23, 2022
@ndricimrr ndricimrr added the bug Something isn't working label Jun 24, 2022
@ndricimrr ndricimrr changed the title Refactor buildpath getcurrentpath Refactor buildpath for getcurrentpath Jun 24, 2022
core/src/App.svelte Outdated Show resolved Hide resolved
core/src/App.svelte Outdated Show resolved Hide resolved
@ndricimrr ndricimrr merged commit db10e5e into master Jun 28, 2022
@ndricimrr ndricimrr deleted the refactor-buildpath-getcurrentpath branch June 28, 2022 13:44
@JohannesDoberer JohannesDoberer mentioned this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request refactoring Something needs to be refactored in a separate task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor buildPathForGetCurrent function
2 participants