Support JWT authentication method #201
Conversation
|
|
|
@jeffalbion Can you please review and merge this pull request |
lib/protocol/auth/JWT.js
Outdated
| @@ -0,0 +1,40 @@ | |||
| // Copyright 2022 SAP AG. | |||
There was a problem hiding this comment.
I believe this should be 'SAP SE'
There was a problem hiding this comment.
Ah, Copy&Paste error. The other files still have SAP AG as they where before the change from AG to SE. I fixed it for this file.
|
Hi @jeffalbion I just saw that JWT was never explained in the SAP HANA SQL Command Network Protocol Reference. Do you know who is responsible for this document? As LDAP is already explained in the document but yet never implemented in any open source client, would be OK to implement it here? |
|
Hi @cplussharp, The HANA Clients development team at SAP is responsible for the document but it has indeed fallen out of date and was removed in the HANA 2.0 SPS05 help guide. We generally keep internal notes amongst our team now and refer to the source code directly for any questions. If there is a larger demand for LDAP support for hdb our team can also take a look at enhancing the driver but we haven't heard of any requests to date to my knowledge. LDAP is supported in SAP HANA Cloud now so I agree the support could be useful in some scenarios. Since this is a community-based driver PR requests are always welcome but please let us know if you're starting work on a major feature like LDAP support so we don't duplicate efforts. Thanks for your work for the JWT support! |
JWT works more or less the same as SAML from a client perspective.