Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LDAP authentication #209

Merged
merged 3 commits into from Apr 20, 2023
Merged

Support LDAP authentication #209

merged 3 commits into from Apr 20, 2023

Conversation

cplussharp
Copy link
Contributor

No description provided.

@cplussharp
Copy link
Contributor Author

Hi @jeffalbion, can you please review this pull-request.
Sadly it is not possible to write e2e tests for LDAP as we would need credentials for a public LDAP server.

@cplussharp
Copy link
Contributor Author

Hi @jeffalbion if everything is OK with this change, can you please merge it?

@jeffalbion jeffalbion merged commit 3f5b524 into SAP:master Apr 20, 2023
@cplussharp cplussharp deleted the ldap_support branch July 13, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffalbion jeffalbion jeffalbion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cplussharp @jeffalbion