Specify path option 'node_node/node-rfc' in 'noderfc-bindings.ts' #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nonoll
commented
Aug 9, 2023
nonoll
commented
- Specify path option 'node_node/node-rfc' in 'noderfc-bindings.ts' #294
bsrdjan
approved these changes
Aug 15, 2023
|
Thank you @nonoll for finding and fixing this issue. I just link this SO issue, as a reminder how complex can be search for node app working directory. Env variable can help in more scenarios as you said. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.