Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@sap-ux/annotation-converter): Remove the setter for lazy properties #447

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drktfl
Copy link
Contributor

@drktfl drktfl commented Feb 24, 2023

This makes lazy properties read-only but leaves the rest of the converted structure mutable. It is a (small) first step towards an immutable structure.

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2023

⚠️ No Changeset found

Latest commit: b3a199c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@nlunets nlunets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, do you want to try this commit against FE first ?
@stefanschreck do you reckon this might be dangerous for you ? :)

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@drktfl
Copy link
Contributor Author

drktfl commented Feb 24, 2023

I'm doing some tests right now. I would actually assume that we cannot simply make the output (or parts of it) immutable without any effect on consuming code

@drktfl
Copy link
Contributor Author

drktfl commented Feb 24, 2023

I'm doing some tests right now

Works in FE. Can't tell about other consumers; @stefanschreck: This would make it impossible to set some (not all) properties on the converted output - those that are created through by the lazy() function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants