Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(preview-middleware): Add NavTargetResolution #1842

Closed
wants to merge 3 commits into from

Conversation

heimwege
Copy link
Contributor

@heimwege heimwege commented Apr 17, 2024

fixes #1841

I successfully tested a fiori elements app with 1.120.11 and 1.122.2, someone needs to test non-fe apps in 1.122.x and < 1.122.x before merge to ensure they are fine as well.

Copy link

changeset-bot bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: 0664afc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/preview-middleware Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heimwege heimwege added bug Something isn't working preview-middleware @sap-ux/preview-middleware labels Apr 17, 2024
@heimwege heimwege marked this pull request as ready for review April 17, 2024 08:57
@heimwege heimwege requested a review from a team as a code owner April 17, 2024 08:57
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@zdravko-georgiev zdravko-georgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed this issue seems to be UI5 related. Therefore a fix might be provided by UI5 team. Please don't merge yet.

@heimwege
Copy link
Contributor Author

This fix is no longer needed. Will be fixed by UI5 in 1.24.x

@heimwege heimwege closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview-middleware @sap-ux/preview-middleware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG - preview middleware served launchpad not able to navigate to (fiori elements) application in UI5 122.x
2 participants