Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(preview-middleware): Add NavTargetResolution #1842

Closed
wants to merge 3 commits into from
Closed

Fix(preview-middleware): Add NavTargetResolution #1842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1b2637
adjust sandbox.html template
heimwege Apr 17, 2024
ce86f56
add changeset
heimwege Apr 17, 2024
0664afc
Merge branch 'main' into fix/1841/add-NavTargetResolution
heimwege Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nervous-eyes-march.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sap-ux/preview-middleware': patch
---

Add ushell sandbox (=launchpad) configuration for NavTargetResolution
8 changes: 8 additions & 0 deletions packages/preview-middleware/templates/flp/sandbox.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@
}
}
},
services: {
NavTargetResolution: {
config: {
allowTestUrlComponentConfig: true,
enableClientSideTargetResolution: true
}
}
},
applications: <%- JSON.stringify(apps) %>
};
</script>
Expand Down
40 changes: 40 additions & 0 deletions packages/preview-middleware/test/unit/base/__snapshots__/flp.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,14 @@ exports[`FlpSandbox router editor with config 1`] = `
}
}
},
services: {
NavTargetResolution: {
config: {
allowTestUrlComponentConfig: true,
enableClientSideTargetResolution: true
}
}
},
applications: {\\"app-preview\\":{\\"title\\":\\"My Simple App\\",\\"description\\":\\"This is a very simple application.\\",\\"additionalInformation\\":\\"SAPUI5.Component=test.fe.v2.app\\",\\"applicationType\\":\\"URL\\",\\"url\\":\\"..\\",\\"applicationDependencies\\":{\\"manifest\\":true}},\\"testfev2other-preview\\":{\\"title\\":\\"My Other App\\",\\"description\\":\\"This is a very simple application.\\",\\"additionalInformation\\":\\"SAPUI5.Component=test.fe.v2.other\\",\\"applicationType\\":\\"URL\\",\\"url\\":\\"/yet/another/app\\",\\"applicationDependencies\\":{\\"manifest\\":true}}}
};
</script>
Expand Down Expand Up @@ -559,6 +567,14 @@ exports[`FlpSandbox router rta 1`] = `
}
}
},
services: {
NavTargetResolution: {
config: {
allowTestUrlComponentConfig: true,
enableClientSideTargetResolution: true
}
}
},
applications: {\\"app-preview\\":{\\"title\\":\\"My Simple App\\",\\"description\\":\\"This is a very simple application.\\",\\"additionalInformation\\":\\"SAPUI5.Component=test.fe.v2.app\\",\\"applicationType\\":\\"URL\\",\\"url\\":\\"..\\",\\"applicationDependencies\\":{\\"manifest\\":true}},\\"testfev2other-preview\\":{\\"title\\":\\"My Other App\\",\\"description\\":\\"This is a very simple application.\\",\\"additionalInformation\\":\\"SAPUI5.Component=test.fe.v2.other\\",\\"applicationType\\":\\"URL\\",\\"url\\":\\"/yet/another/app\\",\\"applicationDependencies\\":{\\"manifest\\":true}}}
};
</script>
Expand Down Expand Up @@ -666,6 +682,14 @@ exports[`FlpSandbox router rta with developerMode=true 2`] = `
}
}
},
services: {
NavTargetResolution: {
config: {
allowTestUrlComponentConfig: true,
enableClientSideTargetResolution: true
}
}
},
applications: {\\"app-preview\\":{\\"title\\":\\"My Simple App\\",\\"description\\":\\"This is a very simple application.\\",\\"additionalInformation\\":\\"SAPUI5.Component=test.fe.v2.app\\",\\"applicationType\\":\\"URL\\",\\"url\\":\\"..\\",\\"applicationDependencies\\":{\\"manifest\\":true}},\\"testfev2other-preview\\":{\\"title\\":\\"My Other App\\",\\"description\\":\\"This is a very simple application.\\",\\"additionalInformation\\":\\"SAPUI5.Component=test.fe.v2.other\\",\\"applicationType\\":\\"URL\\",\\"url\\":\\"/yet/another/app\\",\\"applicationDependencies\\":{\\"manifest\\":true}}}
};
</script>
Expand Down Expand Up @@ -746,6 +770,14 @@ exports[`FlpSandbox router rta with developerMode=true and plugin 1`] = `
}
}
},
services: {
NavTargetResolution: {
config: {
allowTestUrlComponentConfig: true,
enableClientSideTargetResolution: true
}
}
},
applications: {\\"app-preview\\":{\\"title\\":\\"My Simple App\\",\\"description\\":\\"This is a very simple application.\\",\\"additionalInformation\\":\\"SAPUI5.Component=test.fe.v2.app\\",\\"applicationType\\":\\"URL\\",\\"url\\":\\"..\\",\\"applicationDependencies\\":{\\"manifest\\":true}},\\"testfev2other-preview\\":{\\"title\\":\\"My Other App\\",\\"description\\":\\"This is a very simple application.\\",\\"additionalInformation\\":\\"SAPUI5.Component=test.fe.v2.other\\",\\"applicationType\\":\\"URL\\",\\"url\\":\\"/yet/another/app\\",\\"applicationDependencies\\":{\\"manifest\\":true}}}
};
</script>
Expand Down Expand Up @@ -826,6 +858,14 @@ exports[`FlpSandbox router test/flp.html 1`] = `
}
}
},
services: {
NavTargetResolution: {
config: {
allowTestUrlComponentConfig: true,
enableClientSideTargetResolution: true
}
}
},
applications: {\\"app-preview\\":{\\"title\\":\\"My Simple App\\",\\"description\\":\\"This is a very simple application.\\",\\"additionalInformation\\":\\"SAPUI5.Component=test.fe.v2.app\\",\\"applicationType\\":\\"URL\\",\\"url\\":\\"..\\",\\"applicationDependencies\\":{\\"manifest\\":true}},\\"testfev2other-preview\\":{\\"title\\":\\"My Other App\\",\\"description\\":\\"This is a very simple application.\\",\\"additionalInformation\\":\\"SAPUI5.Component=test.fe.v2.other\\",\\"applicationType\\":\\"URL\\",\\"url\\":\\"/yet/another/app\\",\\"applicationDependencies\\":{\\"manifest\\":true}}}
};
</script>
Expand Down