Fix: middleware crashes when manifest.json is missing or not where it was expected

[tobiasqueck]

Fix for #1051

[changeset-bot]

🦋 Changeset detected

Latest commit: 2f9db7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sap-ux/ui5-proxy-middleware	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ullasholla]

@tobiasqueck, thanks for the PR.

• patch changeset looks correct
• the code is readable and clean
• tests cover most of the changes

I had a few minor comments, could you please take a look when you can? Cheers.

[tobiasqueck]

@ullasholla please re-review, I believe, I have addressed all your concerns
@zdravko-georgiev would you be available for the 2nd review?

[ullasholla]

@tobiasqueck, thanks for addressing all the review comments.

[tobiasqueck]

@Klaus-Keller thanks for your direct message. I have enhanced the test/test-input folder with a test setup for local testing. Just go to test/test-input/easy-ui5-app and then run npm i && npm start.
With this fix it will work as expected, without the fix the middleware will crash.

[Klaus-Keller]

Hi @tobiasqueck,
I like the approach to use resources to look up manifest.json, but would then remove the code in utils.ts that reads the manifest. See my comments.

[tobiasqueck]

but would then remove the code in utils.ts that reads the manifest.

We tried to keep a clean separation of code specific to running this middleware in the ui5 tooling compared to code independent of the UI5 tooling. This new function is specific to the ui5 tooling therefore it should not move to the utils.
We use this separation in all our middlewares.

[Klaus-Keller]

• code changes to fix the wrong lookup of manifest.json look good and are easy to understand
• build and tested locally
• code coverage looks great
• thanks for adding types definitions

Approved from my side

[815are]

Checked:

1. Code is easy to understand - I did not notice issue;
2. Tests are maintained - scenarios listed in bug are covered

I did not test locally.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

97.4% Coverage
0.0% Duplication