Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add default content for extension points to the outline in CPE #1867

Merged
merged 23 commits into from
May 23, 2024
Merged

feat: Add default content for extension points to the outline in CPE #1867

merged 23 commits into from
May 23, 2024

Conversation

nikmace
Copy link
Contributor

@nikmace nikmace commented Apr 25, 2024

Feat for #1866.

  • Enhances outline nodes transformation for extension points that have default content.
  • Add default content to the outline tree in CPE.
  • Shows information message to the user if extension point has default content

@nikmace nikmace added preview-middleware @sap-ux/preview-middleware preview-middleware-client control-property-editor @sap-ux/control-property-editor labels Apr 25, 2024
@nikmace nikmace self-assigned this Apr 25, 2024
@nikmace nikmace requested review from a team as code owners April 25, 2024 11:52
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2024 •
edited

🦋 Changeset detected

Latest commit: 29343a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/control-property-editor Patch
@sap-ux-private/control-property-editor-common Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikmace nikmace added the feature New feature or request label Apr 25, 2024
@nikmace nikmace requested a review from a team April 25, 2024 11:53
@nikmace nikmace requested review from GDamyanov and voicis May 7, 2024 07:14
GDamyanov
GDamyanov requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@GDamyanov GDamyanov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed.
Code looks good to me.
Good test coverage.
Manual testing not done.

packages/control-property-editor/src/panels/outline/Tree.tsx Show resolved Hide resolved
@nikmace nikmace requested a review from GDamyanov May 8, 2024 06:51
GDamyanov
GDamyanov previously approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@GDamyanov GDamyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve again after base branch merge.

@nikmace nikmace requested review from voicis and GDamyanov May 10, 2024 10:37
voicis
voicis approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code adheres to development guidelines
  • Good test coverage
  • Review comments addressed
  • Did not test manually, only inspected the code changes

GDamyanov
GDamyanov approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@GDamyanov GDamyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code looks good.
  • All review comments addressed,
  • Excellent test coverage.
  • Did not test manually.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nikmace nikmace merged commit 56d8b0b into main May 23, 2024
13 checks passed
@nikmace nikmace deleted the feat/1866/default-content-outline branch May 23, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voicis voicis voicis approved these changes

@GDamyanov GDamyanov GDamyanov approved these changes

Assignees

@nikmace nikmace

Labels
control-property-editor @sap-ux/control-property-editor feature New feature or request preview-middleware @sap-ux/preview-middleware preview-middleware-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikmace @voicis @GDamyanov