-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Controller Extension only on async views in Adp projects #1874
feat: Adding Controller Extension only on async views in Adp projects #1874
Conversation
🦋 Changeset detectedLatest commit: fb1f5f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…pps-with-sync-views
…pps-with-sync-views
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments addressed
Code looks good
Did not test manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code changes looks good
- Changeset present
- Good test coverage
- Did not test manually
If we need to add more dialogs in the future, we should look into how to better handle that logic, because it is slowly starting to get out of hand.
Also if we get more user facing texts coming from the preview middleware client, we should start using i18n mechanisms there as well.
…pps-with-sync-views
…pps-with-sync-views
…pps-with-sync-views
Quality Gate passedIssues Measures |
Feat for #1869