Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Step_19_Reuse_Dialogs_1945396.md #57

Closed
wants to merge 1 commit into from

Conversation

FabioNascimento
Copy link

That Dialog don`t open With por que o the method getRootControl only is return value when that loaded completed. The file in the api Samples Was corrected.

That Dialog don`t open With por que o the method getRootControl only is return value when that loaded completed. The file in the api Samples Was corrected.
@CLAassistant
Copy link

CLAassistant commented Aug 10, 2021

CLA assistant check
All committers have signed the CLA.

@boghyon
Copy link
Contributor

boghyon commented Aug 10, 2021

@FabioNascimento There is currently an ongoing refactoring in the walkthrough samples. The latest Component.js file in the step 19, for example, doesn't call this.rootControlLoaded() anymore: https://github.com/SAP/openui5/blob/c05eaed493fd328b0d80e73c0a15c19889db7120/src/sap.m/test/sap/m/demokit/tutorial/walkthrough/19/webapp/Component.js

The change was merged into OpenUI5 just today (SAP/openui5@e71bef4#diff-f6a558bd9fc23bb8788fd852231242073b89c6594710566a04a8c87845ecc17a) to make use of the new loadFragment API in the controller.

I'm guessing that the text and the code snippets from the Walkthrough were already planned to be adapted accordingly by one of the maintainers.

@OlMue
Copy link
Collaborator

OlMue commented Jan 19, 2022

Hi all, sorry for the super late reply. We have removed the whole step from the tutorial with 1.94 (released on Sep. 9, 2021), so this is no longer relevant. But thanks a lot for your contribution! 👍

@OlMue OlMue closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants