Demo Kit Demo App "Application Best Practices "Add new product" not working with german locale

[cherderi]

OpenUI5 version: openui5-sdk-1.22.8

Browser/version (+device/version): Firefox 32.0 Windows 7 32 bit German locale

Any other tested browsers/devices(OK/FAIL): no other device / browser tested

URL (minimal example if possible):
/openui5-sdk-1.22.8/test-resources/sap/m/demokit/tdg/index.html?responderOn=true

User/password (if required and possible - do not post any confidential information here):

Steps to reproduce the problem:

1. Start demo app "Application Best Practives"
2. Press + to add new product
3. Choose 15.9.2014 (German date notation) from the datepicker in field "Release Date:"
   Additionally fill in the other fields like "Product Name" ....
4. Press Save button

What is the expected result?
New product should be added

What happens instead?
Pop up: Warnung Problem creating new product.
A new product is not created.

Any other information? (attach screenshot if possible)
See screenshot.

I think this issue might be a side effect of fixing issue #90

[matz3]

Hi,

thanks for reporting.
This seems to be an issue in the application itself.
The view binds to the "value" property of the DateTimeInput control. This contains the value that is displayed in the input (locale specific). To create the product the Date object is needed which is populated by the "dateValue" property, so the binding needs to be adopted here.
Furthermore the "dateFromString" method in the controller is not needed anymore as the model should then already contain a valid Date object.

I'll forward this to the corresponding colleague.

EDIT:
Internal ticket: 0120031469 0000692208 2014

Best regards,
Matthias

[cherderi]

Hallo Matthias,

ich arbeite gerade das Entwicklerhandbuch des openui5 durch.
Ich komme mir komisch vor, wenn ich für jeden kleinen Fehler in diesem
Dokument einen bug auf github erstelle.

Kannst du mir sagen, wie das gewünschte Vorgehen bezüglich
Dokumentationsfehlern im Developer Guide ist.

Viele Grüße

Christoph Herderich

Am 17.09.2014 um 20:08 schrieb Matthias Oßwald:

Hi,

thanks for reporting.
This seems to be an issue in the application itself.
The view binds to the "value" property of the DateTimeInput control.
This contains the value that is displayed in the input (locale
specific). To create the product the Date object is needed which is
populated by the "dateValue" property, so the binding needs to be
adopted here.
Furthermore the "dateFromString" method in the controller is not
needed anymore as the model should then already contain a valid Date
object.

I'll forward this to the corresponding colleague.

Best regards,
Matthias

—
Reply to this email directly or view it on GitHub
#140 (comment).

Christoph Herderich

SmallCases GmbH, Salzstraße 9, 79098 Freiburg
Softwareprojekte, Beratung und Ausführung

Telefon: 0761 38845820, Mobil: 0170 7894130
E-Mail: christoph.herderich@smallcases.de

Ust.-IDNr: DE207693209, Handelsreg: Freiburg HRB 413090
GLS Gemeinschaftsbank eG BLZ: 43060967, Konto-Nr: 8042526000
Internet: www.smallcases.de
Geschäftsführer: Bertram Stoll, Frank Lipps, Matthias Pfefferle

[TobiasOetzel]

Hi Christoph,

für uns ist das garkein so kleiner fehler wenn etwas in unserem Hauptguide falsch ist.
Deswegen sind wir sehr dankbar wenn du das so reportest!

Der issue tracker von github ist dafür auch sehr gut geeignet, da wir dann den Überblick behalten.

viele Grüße,
Tobias

[matz3]

I am closing this issue as the TDG app has been removed via 8bb457d in favor of new best practices apps. See #414 for more information.