ManagedObject: properties awaiting function should have type: "function" instead of type: "any"

[boghyon]

Since 7f32a36 & 860805d, it is possible to define "function" as a type of property. However, many modules, derived from ManagedObject, still use the type "any" whereas a function is awaited.

It would be nice if they adapt to the "new" type so that at least the API Reference can display the type correctly.

URL (minimal example if possible):

• sap.m.Dialog: escapeHandler --> Fixed by 16fad20
• sap.m.MessageView: --> Fixed by 32e2e17
  • asyncDescriptionHandler
  • asyncURLHandler
• sap.m.MessagePopover --> Fixed by 32e2e17
  • asyncDescriptionHandler
  • asyncURLHandler
• sap.m.Input: --> Fixed by 32e2e17
  • textFormatter
  • suggestionRowValidator
• sap.ui.table.AnalyticalColumn: groupHeaderFormatter --> Fixed by 219630c

... Probably more (didn't check closed sourced modules)

What is the expected result?

type: "function" if applicable.

What happens instead?

type: "any"

[gerym]

Hello @boghyon ,

Thank you for sharing this finding. I've created an internal incident 1870103964 and the colleagues will comment here in GitHub if the change is possible.

Regards,
Gery

[codeworrior]

I considered to adapt those controls when I introduced the type function but the problem was strict compatibility. Type any allows values other than functions and the control implementations either might have validated on their own and thrown an exception (then using 'function' would be okay). Or they might have tolerated and ignored non-function values. Then the type is not easily usable or at least requires a deeper analysis of the potential impact.

That doesn't mean it can't be done, but we have to leave the decision up to the control owners.

[jdichev]

Hi,

I checked the respective controls as (co-)owner/author of involved code in Dialog, MessageView and MessagePopover. The discussed change should have already be done - we were just not aware of the new API.

Type 'any' is there for historical reasons and used only because of no better alternative at the time of implementation.

Best regards,
Jordan

[flovogt]

Internal incidents are created

• sap/m/MessageView: 2270115809 by 32e2e17
• sap/m/MessagePopover: 2270115810 by 32e2e17
• sap/m/Input: 2270115891 by 32e2e17
• sap.ui.table.AnalyticalColumn: 2270115892 by 219630c