Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary Actions Not Emphasized #2254

Closed
9 tasks done
boghyon opened this issue Oct 19, 2018 · 1 comment
Closed
9 tasks done

Primary Actions Not Emphasized #2254

boghyon opened this issue Oct 19, 2018 · 1 comment
Labels
enhancement in progress

Comments

@boghyon
Copy link
Contributor

boghyon commented Oct 19, 2018 •
edited

According to the Fiori Design Guideline as well as many other UX guidelines, the primary action on the screen should be emphasized.

Always use an emphasized button for the the standard action. Emphasizing the main action in the dialog toolbar helps users to focus on the most likely choice. This saves users time and gives new users a sense of orientation.
dialog_with_emphasized_button

Also worth watching: How to Communicate Primary Actions (by Luke Wroblewski)

URL (minimal example if possible)

Controls with main / primary action but not yet emphasized:

What is the expected result?

Main action buttons such as OK or Submit are emphasized like in the ValueHelpDialog or ViewSettingsDialog for example.
@ghristanov ghristanov self-assigned this Oct 22, 2018
@ghristanov
Copy link
Contributor

Hello @boghyon ,

Thank you for sharing your enhancement proposal. I've created an internal incident 1880659270. The status of the issue will be updated here in GitHub.

Regards,
Georgi

@ghristanov ghristanov removed their assignment Oct 26, 2018
@boghyon boghyon changed the title Main Actions Are Not Emphasized in Some Controls Primary Actions Not Emphasized Dec 1, 2018
boghyon referenced this issue Dec 21, 2018
@dimovpetar
[INTERNAL] Fiori 3 theme controls adjustments
cb93939 
Change-Id: I443e247d7653e7a8cb126055d7e8a20479b06e2a
JIRA: BGSOFUIRODOPI-1891
This was referenced Aug 23, 2019
Closed
Closed
@boghyon boghyon mentioned this issue Sep 5, 2019
Closed
openui5bot pushed a commit that referenced this issue Sep 10, 2019
@boghyon @nnaydenow
[INTERNAL] Sample settings dialog: emphasize primary action
b59cbce 
Aligning with Fiori Design Guidelines (see #2254)

Change-Id: Iba6b365c86426a0716427fa75e8b884d4ccc5061
Closes: #2641
openui5bot pushed a commit that referenced this issue Nov 15, 2019
@boghyon @jdichev
[INTERNAL] Demo Kit feedback dialog: emphasize primary action
e3cae3a 
Aligning with Fiori Design Guidelines (see #2254)

Closes #2663

Change-Id: I50ba2a6c0c68462aceda3faeb5d8c9c7d5bf6259
BCP: 1970587627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[INTERNAL] sap.ui.unified.ColorPickerPopover: emphasize primary action
2 participants
@ghristanov @boghyon