Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap.m.splitapp master button not available on iphone ios 7.1 #30

Closed
hschaefer123 opened this issue Apr 2, 2014 · 7 comments
Closed

Comments

@hschaefer123
Copy link

The 1.18.11 Demo SplitApp
https://openui5.hana.ondemand.com/test-resources/sap/m/demokit/splitapp/index.html
does not show a Master Button on iphone!

I am only able to see the detail page section on iphone.

Maybe the master button rendering is wrong or something with the new used router approcach.

If i understood right, sap.m.splitapp supports browsers, pads and phones also as unified navigation approach.

I also testet 1.18.11 concerning the fix
[FIX] sap.m.SplitContainer/SplitApp: recreate showMasterButton when it's destroyed during page navigation.

Also chrome iphone emulator does not render a master button inside header.

Cheers Holger

@akudev
Copy link
Contributor

akudev commented Apr 3, 2014

Hi Holger,

hm... yes, that looks wrong.

Indeed, SplitApp can be used for responsive master-detail behavior across all platforms/devices:
in big desktop windows you will see master and detail area, on tablets in portrait mode (or small windows) you will see only the detail page and you can make the master area visible, e.g. with the mentioned button. On phones there is no master button, but you should initially see the master area and navigate from there to the detail area by selecting items.
This is not happening in the SplitApp example page.

But I think this is an issue with this demo app, not with the control - other SplitApp-based apps work fine, can you confirm?
E.g.:
https://openui5.hana.ondemand.com/test-resources/sap/m/demokit/explored/index.html
https://openui5.hana.ondemand.com/test-resources/sap/m/demokit/poa/index.html

Thanks for reporting, we'll have a look at this app.

Regards
Andreas

@akudev akudev added the bug label Apr 3, 2014
@hschaefer123
Copy link
Author

Hi Andreas,
after digging down the full code of splitapp, splitcontainer i found out,
that there is no support for the master button on phone (sadly!).

In my opion, the same solution would be helpful if you use on master page
as a navigator between different app solutions.

So i can confirm this is currently an issue by design, not a bug.

The behavior is not quite clear!

If you use the router, you have to make sure that you use something like
pattern : (jQuery.device.is.phone) ? "leistung" : "",

If not, you will not be able to navigate back to the master!

Also on !phone devices, you need to empty patterns to automatically load
initial master and detail page.

Every detail home view now needs something like

showNavButton="{device>/isPhone}"
navButtonPress="onNavButtonPress"
class="MasterButton"

to emulate the same behavior on phones and to be able to navigate to master

onNavButtonPress : function (evt) {
this.router.navTo("navigator");
},

Maybe you are able to place a feature request, that the ShowMaster button
will also be supported on phone! In my opion that would be a useful feature
to have out-of-the-box navigation also on phones (even if there is only one
nav aggregation).

The SplitContainer code looks quite good (using transitions and an ie9
fallback with jquery transformation). I will prototype some methods and css
to offer an facebook like menu out-of-the-box and will place the example on
my OpenUI5 Blog (http://openui5.blogspot.com).

I am just migrating from Sencha Libs and i think there are a lot of thinks
that i have to do by my own till i have the same framework i am used ;-)

Thanks for your feedback.

Cheers Holger

Holger Schäfer
Dipl.-Wirt.-Inf.
Mobile: +49 (170) 6363186
Email: holger.schaefer@gmail.com
Location: Germany, Dortmund
[image: Facebook] http://www.facebook.com/profile.php?id=1143362937 [image:
Twitter] https://twitter.com/hschaefer123 [image:
LinkedIn]http://www.linkedin.com/profile/view?id=11915235
[image: XING] https://www.xing.com/profile/Holger_Schaefer4 [image:
Google Plus Page] https://plus.google.com/u/0/101663472963508114093/posts

On Thu, Apr 3, 2014 at 9:40 AM, Andreas Kunz notifications@github.comwrote:

Hi Holger,

hm... yes, that looks wrong.

Indeed, SplitApp can be used for responsive master-detail behavior across
all platforms/devices:
in big desktop windows you will see master and detail area, on tablets in
portrait mode (or small windows) you will see only the detail page and you
can make the master area visible, e.g. with the mentioned button. On phones
there is no master button, but you should initially see the master area and
navigate from there to the detail area by selecting items.
This is not happening in the SplitApp example page.

But I think this is an issue with this demo app, not with the control -
other SplitApp-based apps work fine, can you confirm?
E.g.:

https://openui5.hana.ondemand.com/test-resources/sap/m/demokit/explored/index.html

https://openui5.hana.ondemand.com/test-resources/sap/m/demokit/poa/index.html

Thanks for reporting, we'll have a look at this app.

Regards
Andreas


Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-39421227
.

@akudev
Copy link
Contributor

akudev commented Apr 4, 2014

Hi Holger,

thanks for your detailed description of what you would have expected.

The SplitApp is designed to behave like e.g. the "Settings" app on iPhone, where a master-detail structure on tablet is mapped to a linear set of pages on phone. As such it is correct not to display a "Show Master" button.
I can for sure mention this as enhancement request, but to be honest, I wouldn't expect it to happen very soon.
One reason is that the facebook-like menu use-case is also covered by other control(s) which are not very prominent yet, so you may very well not have noticed them:
the sap.ui.unified.Shell, and sap.ui.unified.SplitContainer. Both can move in a menu pane from the left, and the Shell even ALWAYS has a menu button. ;-)
So maybe they are what you are looking for.

See:
https://openui5.hana.ondemand.com/#docs/api/symbols/sap.ui.unified.Shell.html
https://openui5.hana.ondemand.com/#docs/api/symbols/sap.ui.unified.SplitContainer.html
https://openui5.hana.ondemand.com/test-resources/sap/ui/unified/Shell.html
https://openui5.hana.ondemand.com/test-resources/sap/ui/unified/SplitContainer.html

I'll keep this issue report focused on the SplitApp demo page issue, which is a bug, and close it when fixed.

Regards
Andreas

@stopcoder
Copy link
Member

Hi Holger,

the SplitApp demo page issue was caused by the implementation of navigation handling within this application. When it runs on the phone, the first page in master area should be shown instead of the first page in detail area.

The issue is fixed now. The fix will be available in patch 1.18.12 and also in the 1.20.4 release.

Best regards,
Jiawei

@akudev akudev added the fixed label Apr 11, 2014
@akudev
Copy link
Contributor

akudev commented Apr 11, 2014

Closing, as the real issue (the empty page in the demo app) was fixed.

(As already said: the fact that the master button is not present on phones is intentional and consistent with other mobile UIs.)

Thanks for reporting!

@akudev akudev closed this as completed Apr 11, 2014
@SunboX
Copy link

SunboX commented Nov 11, 2015

I expected the same behavior as @hschaefer123 and it worked like expected in small browser windows ... but not on phone. Than I came across this, wasn't clear to me, too.

@StErMi
Copy link

StErMi commented Jul 25, 2018

I've just tested it on a hybrid app I've just developed and I have the same issue. The library I'm using is OpenUI5 v1.50.8

How can I fix it? Also it happens on the browser when I try to emulate a device (chrome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants