model: fix default Edm.DateTimeOffset value (#195) #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2022
|
Well, since the Edm.DateTime default value is also causing problems, as you find out in issue #79, why not change both Edm.DateTime and Edm.DateTimeOffset to the January 1, 1753 A.D, noted in this comment |
|
note: not sure why, but build was not triggered for this PR |
|
Could you please rebase to the latest master (I don't like merge commits). |
phanak-sap
requested changes
Jan 27, 2022
rettichschnidi
force-pushed
the
rs/upstream/fix-default-Edm.DateTimeOffset-value
branch
3 times, most recently
from
22fbe4c
to
4293d43
Compare
Default value was broken in several ways: - Month 0 does not exist - Day 0 does not exist - Year 0 can not be handled by Python datetime
This makes it easier, more likely, to spot dates fixed-up by pyodata. The new value aligns with Edm.DateTimeOffset.
rettichschnidi
force-pushed
the
rs/upstream/fix-default-Edm.DateTimeOffset-value
branch
from
4293d43
to
a264bac
Compare
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 92.66% 92.81% +0.14%
==========================================
Files 6 6
Lines 2768 2768
==========================================
+ Hits 2565 2569 +4
+ Misses 203 199 -4
Continue to review full report at Codecov.
|
|
Thanks for the fix. Good work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default value was broken in several ways:
The new default value is copied from Edm.DateTime for consistency reasons. However, choosing something less common like 1.1.1 or 1.1.1970 might be more sensible?