refactor: make anchors compliant with checkmarx (#15932)

Anchors tags have been refactored to be compliant with the new pipeline security check. Attribute 'rel' has been added to anchors that are using _blank as target.
SAP · Jun 30, 2022 · 14ab49c · 14ab49c
1 parent b4b8445
commit 14ab49c
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 4 deletions.
diff --git a/...re-libs/checkout/base/components/checkout-place-order/checkout-place-order.component.html b/...re-libs/checkout/base/components/checkout-place-order/checkout-place-order.component.html
@@ -12,6 +12,7 @@
           [routerLink]="{ cxRoute: 'termsAndConditions' } | cxUrl"
           class="cx-tc-link"
           target="_blank"
+          rel="noopener noreferrer"
         >
           {{ 'checkoutReview.termsAndConditions' | cxTranslate }}
         </a>

diff --git a/...heduled-replenishment/components/checkout-place-order/checkout-place-order.component.html b/...heduled-replenishment/components/checkout-place-order/checkout-place-order.component.html
@@ -12,6 +12,7 @@
           [routerLink]="{ cxRoute: 'termsAndConditions' } | cxUrl"
           class="cx-tc-link"
           target="_blank"
+          rel="noopener noreferrer"
         >
           {{ 'checkoutReview.termsAndConditions' | cxTranslate }}
         </a>

diff --git a/...ls/order-detail-items/consignment-tracking/tracking-events/tracking-events.component.html b/...ls/order-detail-items/consignment-tracking/tracking-events/tracking-events.component.html
@@ -67,9 +67,12 @@
             </div>
             <div class="shipment-content">
               <ng-container *ngIf="consignmentTracking?.trackingUrl">
-                <a target="_blank" [href]="consignmentTracking.trackingUrl">{{
-                  consignmentTracking?.trackingID
-                }}</a>
+                <a
+                  target="_blank"
+                  rel="noopener noreferrer"
+                  [href]="consignmentTracking.trackingUrl"
+                  >{{ consignmentTracking?.trackingID }}</a
+                >
               </ng-container>
               <ng-container *ngIf="!consignmentTracking?.trackingUrl">
                 <label>

diff --git a/...-libs/storefinder/components/store-finder-list-item/store-finder-list-item.component.html b/...-libs/storefinder/components/store-finder-list-item/store-finder-list-item.component.html
@@ -42,6 +42,7 @@
       aria-hidden="true"
       href="{{ getDirections(location) }}"
       target="_blank"
+      rel="noopener noreferrer"
       class="btn btn-sm btn-action btn-block cx-button"
       (click)="$event.stopPropagation()"
       [attr.aria-label]="'storeFinder.ariaLabelGetDirections' | cxTranslate"

diff --git a/...r/components/store-finder-store-description/store-finder-store-description.component.html b/...r/components/store-finder-store-description/store-finder-store-description.component.html
@@ -22,6 +22,7 @@ <h2 aria-hidden="true">{{ location.displayName || location.name }}</h2>
                 class="cx-link"
                 [href]="getDirections(location)"
                 target="_blank"
+                rel="noopener noreferrer"
                 [attr.aria-label]="
                   'storeFinder.ariaLabelGetDirections' | cxTranslate
                 "

diff --git a/feature-libs/user/profile/components/register/register.component.html b/feature-libs/user/profile/components/register/register.component.html
@@ -173,6 +173,7 @@
                   <a
                     [routerLink]="{ cxRoute: 'termsAndConditions' } | cxUrl"
                     target="_blank"
+                    rel="noopener noreferrer"
                   >
                     {{ 'register.termsAndConditions' | cxTranslate }}
                   </a>

diff --git a/projects/storefrontlib/cms-components/content/pdf/pdf.component.html b/projects/storefrontlib/cms-components/content/pdf/pdf.component.html
@@ -1,6 +1,6 @@
 <ng-container *ngIf="data$ | async as data">
   <div class="pdf-container">
-    <a [href]="url" target="_blank">
+    <a [href]="url" target="_blank" rel="noopener noreferrer">
       <span>{{
         addPdfExtension(
           data?.title ||