Incorrect server request url on server side, when deployed on ccv2

[dunqan]

This mostly affects Automatic Multi-Site Configuration that in many cases won't be able to resolve proper base site.

How to reproduce:

1. Add this snippet to the app.module.ts

  constructor(
    @Optional()
    @Inject(SERVER_REQUEST_URL)
    protected serverRequestUrl?: string
  ) {
    console.log('serverRequestUrl', serverRequestUrl);
  }

2. Check SSR logs (serverRequestUrl will contain local address, instead of request

[Platonn]

Blocks #10903

[Pucek9]

https://sap.service-now.com/now/workspace/agent/record/sn_customerservice_case/72854963dbe1e4d0a827a6b605961959

[dunqan]

We are working on a hotfix that will be included in the next patch release.
Before it will happen, here is a workaround:

1. Copy this code snippet, preferably to separate file alongside app.module.ts app.server.module.ts

import { StaticProvider } from '@angular/core';
import { REQUEST } from '@nguniversal/express-engine/tokens';
import { Request } from 'express';
import { SERVER_REQUEST_ORIGIN, SERVER_REQUEST_URL } from '@spartacus/core';

export const fixServerRequestProviders: StaticProvider[] = [
  {
    provide: SERVER_REQUEST_URL,
    useFactory: getRequestUrl,
    deps: [REQUEST],
  },
  {
    provide: SERVER_REQUEST_ORIGIN,
    useFactory: getRequestOrigin,
    deps: [REQUEST],
  },
];

function getRequestUrl(req: Request): string {
  return getRequestOrigin(req) + req.originalUrl;
}

function getRequestOrigin(req: Request): string {
  // If express is resolving and trusting X-Forwarded-Host, we want to take it
  // into an account to properly generate request origin.
  const trustProxyFn = req.app.get('trust proxy fn');
  let forwardedHost = req.get('X-Forwarded-Host');
  if (forwardedHost && trustProxyFn(req.connection.remoteAddress, 0)) {
    if (forwardedHost.indexOf(',') !== -1) {
      // Note: X-Forwarded-Host is normally only ever a
      //       single value, but this is to be safe.
      forwardedHost = forwardedHost
        .substring(0, forwardedHost.indexOf(','))
        .trimRight();
    }
    return req.protocol + '://' + forwardedHost;
  } else {
    return req.protocol + '://' + req.get('host');
  }
}

2. Add fixServerRequestProviders to providers array in app.module.ts app.server.module.ts

providers: [
  // ...
  ...fixServerRequestProviders
],

3. Enable trust proxy option in server.ts file:

  server.set('trust proxy', 'loopback');

(below const server = express(); line)

[Platonn]

Edited above workaround. Changed app.module.ts to app.server.module.ts. Otherwise in CSR it throws an error:

 NullInjectorError: No provider for InjectionToken REQUEST! ; Zone: <root> ; Task: Promise.then ; Value: NullInjectorError: R3InjectorError(AppModule)[ApplicationModule -> ApplicationRef -> ApplicationInitStatus -> InjectionToken Application Initializer -> [object Object] -> InjectionToken ConfigInitializer -> [object Object] -> OccConfigLoaderService -> InjectionToken SERVER_REQUEST_URL -> InjectionToken REQUEST -> InjectionToken REQUEST -> InjectionToken REQUEST]: 
  NullInjectorError: No provider for InjectionToken REQUEST!

The SERVER_REQUEST_ORIGIN and SERVER_REQUEST_URL should not be provided in CSR by design.

[Platonn]

Edited the above workaround with regards to the latest bugfix 37e8926