Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error logging for unknown http errors #11485

Closed
tobi-or-not-tobi opened this issue Mar 12, 2021 · 0 comments · Fixed by #11486
Closed

Improve error logging for unknown http errors #11485

tobi-or-not-tobi opened this issue Mar 12, 2021 · 0 comments · Fixed by #11486
Assignees
@tobi-or-not-tobi
Labels
error-handling
Projects
MISC (Blamed)
Milestone
3.2

Comments

@tobi-or-not-tobi
Copy link
Contributor

The UnknownErrorHandler is lacking useful information to the logs for devs and operations to understand what's going on when an http request fails. We like to provide more details on which resource failed, and show the errorMessage.
@tobi-or-not-tobi tobi-or-not-tobi added this to the 3.x milestone Mar 12, 2021
@tobi-or-not-tobi tobi-or-not-tobi self-assigned this Mar 12, 2021
@tobi-or-not-tobi tobi-or-not-tobi added this to To Do in MISC (Blamed) via automation Mar 12, 2021
@tobi-or-not-tobi tobi-or-not-tobi mentioned this issue Mar 12, 2021
Merged
tobi-or-not-tobi added a commit that referenced this issue Mar 12, 2021
@tobi-or-not-tobi
Merge branch 'develop' into feature/GH-11485
0bc8aa2
tobi-or-not-tobi added a commit that referenced this issue Mar 14, 2021
@tobi-or-not-tobi
Merge branch 'develop' into feature/GH-11485
154f3af
tobi-or-not-tobi added a commit that referenced this issue Mar 15, 2021
@tobi-or-not-tobi
feat: improve unknown error handling on ssr or in dev mode (#11486)
66e7261 
Previously we've seen some `unknown error -1` in log files on the server (SSR), which didn't give a lot of feedback on the specific error. With this change, we provide a bit more detail to the error at hand. 

closes #11485
@tobi-or-not-tobi tobi-or-not-tobi moved this from To Do to Done in MISC (Blamed) Mar 15, 2021
@tobi-or-not-tobi tobi-or-not-tobi modified the milestones: 3.x, 3.2 Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobi-or-not-tobi tobi-or-not-tobi

Labels
error-handling
Projects
MISC (Blamed)
  
Done
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

feat: improve unknown error handling on ssr or in dev mode SAP/spartacus
1 participant
@tobi-or-not-tobi