Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The popover for old sub list still remains in the screen after switching to new sub section in B2B table (while keyboarding?) #11714

Closed
wangzixi-diablo opened this issue Mar 29, 2021 · 2 comments · Fixed by #12127
Assignees
Labels
a11y/keyboard ⌨️ Issues affecting keyboard-only navigation b2b-mycompany bug Something isn't working Minor
Milestone

Comments

@wangzixi-diablo
Copy link
Contributor

wangzixi-diablo commented Mar 29, 2021

Tell us the version of Spartacus

  • Library version: 3.2.0-next.2, develop branch

To Reproduce
Steps to reproduce the behavior:

  1. open unit list and click one row to enter unit detail page:

image

  1. the (i) icon as the first focusable element in unit detail page is automatically focused. Press enter key, and you can see popover.

image

  1. click Users section to enter unit user sub section. Press enter key. See expected popover in user card:

image

  1. Click Approver section, now the approver sub section is displayed. HOWEVER, the popover for Users is still displayed in the screen:

image

When we click the (i) icon in Approvers card, the corresponding popover can be displayed. Unfortunately, the popover for Users is still in the screen:

image

Expected behavior

When we switch from Users sub section to Approver sub section, the popover for former card should disappear.

Desktop (please complete the following information):

  • OS: windows 10
  • Browser: Chrome
  • Version 89.0.4389.90 (Official Build) (64-bit)

Additional context
Add any other context about the problem here.

@wangzixi-diablo wangzixi-diablo added bug Something isn't working b2b-mycompany labels Mar 29, 2021
@Pucek9 Pucek9 added this to Newly Added in Spartacus Bug Board [can close board?] via automation Apr 6, 2021
@Pucek9 Pucek9 added this to the needs-triage milestone Apr 6, 2021
@wangzixi-diablo
Copy link
Contributor Author

wangzixi-diablo commented Apr 7, 2021

A finding: in step (3), if we manually click (i) icon instead of pressing enter key, and then perform step 4 as usual, then this issue COULD NOT be reproduced.

image

@Xymmer Xymmer moved this from Newly Added to To Do: URGENT in Spartacus Bug Board [can close board?] Apr 8, 2021
@Xymmer Xymmer modified the milestones: needs-triage, 3.2 Apr 8, 2021
@Xymmer Xymmer removed the blocks-3.2 label Apr 8, 2021
@Xymmer Xymmer changed the title The popover for old sub list still remains in the screen after switching to new sub section in B2B table The popover for old sub list still remains in the screen after switching to new sub section in B2B table (while keyboarding?) Apr 8, 2021
@Xymmer Xymmer modified the milestones: 3.2, after-3.2.0 Apr 8, 2021
@Xymmer Xymmer added the a11y/keyboard ⌨️ Issues affecting keyboard-only navigation label Apr 8, 2021
@Xymmer Xymmer moved this from To Do: URGENT to To Do: Next in Spartacus Bug Board [can close board?] Apr 8, 2021
@Xymmer Xymmer moved this from To Do: Next to To Do: URGENT in Spartacus Bug Board [can close board?] Apr 21, 2021
@Xymmer Xymmer moved this from To Do: URGENT to To Do: Next in Spartacus Bug Board [can close board?] Apr 21, 2021
@Pucek9 Pucek9 moved this from To Do: Next to Code Review & Local QA in Spartacus Bug Board [can close board?] Jul 2, 2021
Pucek9 added a commit that referenced this issue Jul 6, 2021
@bgambocjaviniar bgambocjaviniar moved this from Code Review & Local QA to QA from Server Post-Merge in Spartacus Bug Board [can close board?] Jul 9, 2021
@giancorderoortiz
Copy link
Contributor

Issue has been fixed.

@giancorderoortiz giancorderoortiz self-assigned this Jul 14, 2021
@giancorderoortiz giancorderoortiz moved this from QA from Server Post-Merge to Done in Spartacus Bug Board [can close board?] Jul 14, 2021
@Xymmer Xymmer modified the milestones: after-3.2.0, 3.3 Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y/keyboard ⌨️ Issues affecting keyboard-only navigation b2b-mycompany bug Something isn't working Minor
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants