Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HighlightPipe pipe is not exported #7556

Closed
LTiger14 opened this issue May 11, 2020 · 2 comments · Fixed by #12967
Closed

HighlightPipe pipe is not exported #7556

LTiger14 opened this issue May 11, 2020 · 2 comments · Fixed by #12967
Assignees
Labels
bug Something isn't working Minor

Comments

@LTiger14
Copy link

This issue was reported by the community at https://stackoverflow.com/q/61678323/10290115.

Issue

When creating a new component in a storefront extending Spartacus the cxHighlight pipe cannot be imported.

The HighlightPipe is declared in the SearchBoxModule but not exported. Thefore, even when importing the SearchBoxModule you will not have the HighlightPipe.

It's also not possible to declare it in a custom module since it will be declared in two modules, unless SearchBoxModule in not imported.

Acceptance criteria

It should be possible to use the HighlightPipe easily in a Spartacus projected.

@LTiger14 LTiger14 added the bug Something isn't working label May 11, 2020
ravulapati-valtech added a commit to ravulapati-valtech/spartacus that referenced this issue May 13, 2020
@raviavulapati
Copy link

@LTiger14 , as a fix in the PR that I have opened, simply exported HighlightPipe from SearchBoxModule to be able to be used in the custom storefront, let me know if you want a more sophisticated fix by moving HighlightPipe to a dedicate Pipe or related module, would be happy to make the change.

@KateChuen KateChuen added this to the 2.x milestone May 13, 2020
qjimmy added a commit to ravulapati-valtech/spartacus that referenced this issue May 27, 2020
ravulapati-valtech added a commit to ravulapati-valtech/spartacus that referenced this issue Aug 6, 2020
@Xymmer Xymmer added this to Refinement or Discussion Needed in Spartacus Bug Board [can close board?] Dec 15, 2020
@giancorderoortiz
Copy link
Contributor

@LTiger14 is this still an issue in 3.0 or 3.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Minor
Projects
No open projects
4 participants