-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HighlightPipe pipe is not exported #7556
Milestone
Comments
ravulapati-valtech
added a commit
to ravulapati-valtech/spartacus
that referenced
this issue
May 13, 2020
@LTiger14 , as a fix in the PR that I have opened, simply exported HighlightPipe from SearchBoxModule to be able to be used in the custom storefront, let me know if you want a more sophisticated fix by moving HighlightPipe to a dedicate Pipe or related module, would be happy to make the change. |
qjimmy
added a commit
to ravulapati-valtech/spartacus
that referenced
this issue
May 27, 2020
ravulapati-valtech
added a commit
to ravulapati-valtech/spartacus
that referenced
this issue
Aug 6, 2020
Xymmer
added this to Refinement or Discussion Needed
in Spartacus Bug Board [can close board?]
Dec 15, 2020
@LTiger14 is this still an issue in 3.0 or 3.4? |
LTiger14
pushed a commit
that referenced
this issue
Jun 29, 2021
LTiger14
pushed a commit
that referenced
this issue
Jun 29, 2021
LTiger14
pushed a commit
that referenced
this issue
Jun 30, 2021
LTiger14
pushed a commit
that referenced
this issue
Jun 30, 2021
LTiger14
pushed a commit
that referenced
this issue
Jun 30, 2021
LTiger14
pushed a commit
that referenced
this issue
Jun 30, 2021
LTiger14
moved this from Refinement or Discussion Needed
to Done
in Spartacus Bug Board [can close board?]
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was reported by the community at https://stackoverflow.com/q/61678323/10290115.
Issue
When creating a new component in a storefront extending Spartacus the
cxHighlight
pipe cannot be imported.The
HighlightPipe
is declared in theSearchBoxModule
but not exported. Thefore, even when importing theSearchBoxModule
you will not have theHighlightPipe
.It's also not possible to declare it in a custom module since it will be declared in two modules, unless
SearchBoxModule
in not imported.Acceptance criteria
It should be possible to use the
HighlightPipe
easily in a Spartacus projected.The text was updated successfully, but these errors were encountered: