Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CartRemoveEntryFailEvent and CartUpdateEntryFailEvent events #12162

Merged
merged 2 commits into from Apr 30, 2021

Conversation

znikola
Copy link
Contributor

@znikola znikola commented Apr 28, 2021

closes #12125

@znikola znikola requested a review from a team April 28, 2021 11:13
@znikola znikola marked this pull request as draft April 28, 2021 11:13
@cypress
Copy link

cypress bot commented Apr 28, 2021



Test summary

482 0 11 0Flakiness 0


Run details

Project spartacus
Status Passed
Commit 8b64efe ℹ️
Started Apr 29, 2021 7:33 PM
Ended Apr 29, 2021 7:43 PM
Duration 09:28 💡
OS Linux Ubuntu - 18.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@github-actions
Copy link
Contributor

Hosting service deployment

❗ Spartacus deployment failed ( ERR Failed to execute command [application deploy] due to: Error: Deploy
Failed. Could not generate environment or presigned URL.
Response code: 500
Message: Could not deploy new application, the limit: 10 for the
tenant: spartacus has been reached
Type: internal_service_error

). Check job logs for details.)

@github-actions
Copy link
Contributor

Public API changes

✔️ Nothing changed in analyzed entry points.

⚠️ Some entry points are currently impossible to analyze.

Read more
  • @spartacus/asm/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cart/saved-cart/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/administration/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/order-approval - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/rulebased - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefinder/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefront - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:
  • @spartacus/user/account/components - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:
  • @spartacus/user/profile/components - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:

💰 How to debug problems?

Read more

Problem with import() type

It happens when type is deduced by TS based on code and at the same time the deduced type is not present in the file.
In this specific case to support api-extractor it's worth to add type declaration explicitly.

Debugging steps:

  • go to the bot action logs
  • find api-extractor logs for broken library
  • check in which file and line the problems exists
  • build the library locally and check content of the file mentioned in logs (look for import()
  • add explicit type to problematic source code
  • build the library once again and verify that the import( is no longer present
  • commit and push the code with defined type

Problem with import * as ___

Api-extractor doesn't support this namespace syntax.
Check if you really need to use namespace in the library. Try to avoid namespaces when possible.

@znikola znikola marked this pull request as ready for review April 30, 2021 09:49
Copy link
Contributor

@tobi-or-not-tobi tobi-or-not-tobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@znikola znikola merged commit 1f1e8c7 into develop Apr 30, 2021
@znikola znikola deleted the feature/GH-12125 branch April 30, 2021 10:12
@znikola znikola temporarily deployed to dev April 30, 2021 10:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement additional Cart events
2 participants