Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable shipping method radio input when there is ongoing delivery mode request #14401

Merged
merged 35 commits into from
Dec 21, 2021

Conversation

wangzixi-diablo
Copy link
Contributor

@wangzixi-diablo wangzixi-diablo commented Nov 23, 2021

fixes: #14386

@wangzixi-diablo wangzixi-diablo temporarily deployed to dev November 23, 2021 07:35 Inactive
@cypress
Copy link

cypress bot commented Nov 23, 2021



Test summary

682 0 21 0Flakiness 4


Run details

Project spartacus
Status Passed
Commit 82faa25 ℹ️
Started Dec 21, 2021 1:20 AM
Ended Dec 21, 2021 1:38 AM
Duration 18:39 💡
OS Linux Ubuntu - 18.04
Browser Electron 91

View run in Cypress Dashboard ➡️


Flakiness

ssr/pages.e2e-spec.ts Flakiness
1 SSR > should render homepage
2 SSR > should render PLP
3 SSR > should render PDP
regression/infinite-scroll.e2e-spec.ts Flakiness
1 Infinite scroll > should enable infinite scroll and display 'Show more' button

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@wangzixi-diablo wangzixi-diablo temporarily deployed to dev November 23, 2021 08:37 Inactive
@wangzixi-diablo wangzixi-diablo self-assigned this Nov 24, 2021
@wangzixi-diablo wangzixi-diablo changed the title feat: add spinner when there is ongoing delivery mode request feat: disable shipping method radio input when there is ongoing delivery mode request Nov 24, 2021
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev November 24, 2021 03:39 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev November 24, 2021 06:17 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev November 24, 2021 07:10 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev November 24, 2021 08:04 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev November 26, 2021 01:17 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev November 26, 2021 01:55 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev November 26, 2021 02:35 Inactive
@Pucek9 Pucek9 temporarily deployed to dev November 26, 2021 16:29 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev November 29, 2021 09:20 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev November 29, 2021 10:12 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev December 7, 2021 14:55 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev December 8, 2021 07:16 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev December 8, 2021 08:19 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev December 9, 2021 08:49 Inactive
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev December 10, 2021 02:02 Inactive
* Get info about process of setting Delivery Mode, which is done by a HTTP PUT request followed by two HTTP GET request.
* True means at least one quest is still in process, false means all three requests are done
*/
getSetDeliveryModeInProcess(): Observable<boolean> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider a different name for this method

@Pucek9 Pucek9 temporarily deployed to dev December 10, 2021 17:16 Inactive
Pucek9
Pucek9 previously approved these changes Dec 10, 2021
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev December 21, 2021 01:09 Inactive
@github-actions
Copy link
Contributor

Public API changes

⚠️ @spartacus/checkout/components

     // (undocumented)
     get deliveryModeInvalid(): boolean;
     // (undocumented)
+    deliveryModeSetInProcess$: Observable<boolean>;
+    // (undocumented)
     deliveryModeSub: Subscription;
     // (undocumented)
     mode: FormGroup;
@@
     // Warning: (ae-forgotten-export) The symbol "i1" needs to be exported by the entry point public_api.d.ts
     //
     // (undocumented)
-    static ɵmod: i0.ɵɵNgModuleDeclaration<DeliveryModeModule, [typeof i1_8.DeliveryModeComponent], [typeof i1.CommonModule, typeof i3_3.ReactiveFormsModule, typeof i4_2.I18nModule, typeof i3_2.SpinnerModule], [typeof i1_8.DeliveryModeComponent]>;
+    static ɵmod: i0.ɵɵNgModuleDeclaration<DeliveryModeModule, [typeof i1_8.DeliveryModeComponent], [typeof i1.CommonModule, typeof i3_3.ReactiveFormsModule, typeof i4_2.I18nModule, typeof i3_2.SpinnerModule, typeof i4_2.FeaturesConfigModule], [typeof i1_8.DeliveryModeComponent]>;
 }
 
 // @public (undocumented)

⚠️ @spartacus/checkout/core

     getSelectedDeliveryMode(): Observable<DeliveryMode | undefined | null>;
     getSelectedDeliveryModeCode(): Observable<string>;
     getSetDeliveryAddressProcess(): Observable<StateUtils.LoaderState<void>>;
+    getSetDeliveryModeInProcess(): Observable<boolean>;
     getSetDeliveryModeProcess(): Observable<StateUtils.LoaderState<void>>;
     getSupportedDeliveryModes(): Observable<DeliveryMode[]>;
     loadSupportedDeliveryModes(): void;

⚠️ @spartacus/checkout/root

     abstract getSelectedDeliveryMode(): Observable<DeliveryMode | undefined | null>;
     abstract getSelectedDeliveryModeCode(): Observable<string>;
     abstract getSetDeliveryAddressProcess(): Observable<StateUtils.LoaderState<void>>;
+    abstract getSetDeliveryModeInProcess(): Observable<boolean>;
     abstract getSetDeliveryModeProcess(): Observable<StateUtils.LoaderState<void>>;
     abstract getSupportedDeliveryModes(): Observable<DeliveryMode[]>;
     abstract loadSupportedDeliveryModes(): void;

⚠️ Some entry points are currently impossible to analyze.

Read more

💰 How to debug problems?

Read more

@wangzixi-diablo wangzixi-diablo merged commit ccdb511 into develop Dec 21, 2021
@wangzixi-diablo wangzixi-diablo deleted the feature/GH-11386 branch December 21, 2021 07:16
@wangzixi-diablo wangzixi-diablo temporarily deployed to dev December 21, 2021 07:16 Inactive
sam-garland added a commit that referenced this pull request Dec 21, 2021
* test: Add tabScreenshot() method for a11y tab e2e testing (#13818)

Closes: #13686

* feat: disable shipping method radio input when there is ongoing delivery mode request (#14401)

* add spinner when there is onging delivery mode request

* disable radio input instead of using spinner

* fix regression error: only retrieve enabled radio input

* fix broken a18y test

* when loading shipping methods, continue button hiden by spinner

* remove unused flag

* Michal's improvement

* fix broken e2e test

* fix prettier issue

* disable fieldset

* add feature level

* fix unit test after feature level is introduced

* small refactor

* remove log

* add doc for breaking change

* up

* fix disable delay issue

* remove console.log

* add unit test

* add space in comment

* update migration document

* fix build error

* remove duplicate spyOn code

* use BehaviorSubject to improve test

* emit default data in beforeEach

Co-authored-by: Michał Gruca <pucek9@gmail.com>

Co-authored-by: Caine Rotherham <rotherham.c@gmail.com>
Co-authored-by: Jerry Wang <58975336+wangzixi-diablo@users.noreply.github.com>
Co-authored-by: Michał Gruca <pucek9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants