-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable shipping method radio input when there is ongoing delivery mode request #14401
Merged
+324
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
wangzixi-diablo
changed the title
feat: add spinner when there is ongoing delivery mode request
feat: disable shipping method radio input when there is ongoing delivery mode request
Nov 24, 2021
Pucek9
reviewed
Nov 25, 2021
feature-libs/checkout/components/components/delivery-mode/delivery-mode.component.ts
Outdated
Show resolved
Hide resolved
Pucek9
reviewed
Dec 8, 2021
feature-libs/checkout/components/components/delivery-mode/delivery-mode.component.spec.ts
Outdated
Show resolved
Hide resolved
Pucek9
reviewed
Dec 8, 2021
feature-libs/checkout/components/components/delivery-mode/delivery-mode.component.spec.ts
Outdated
Show resolved
Hide resolved
Pucek9
reviewed
Dec 8, 2021
feature-libs/checkout/components/components/delivery-mode/delivery-mode.component.spec.ts
Show resolved
Hide resolved
Pucek9
reviewed
Dec 8, 2021
feature-libs/checkout/components/components/delivery-mode/delivery-mode.component.spec.ts
Outdated
Show resolved
Hide resolved
Pucek9
reviewed
Dec 10, 2021
* Get info about process of setting Delivery Mode, which is done by a HTTP PUT request followed by two HTTP GET request. | ||
* True means at least one quest is still in process, false means all three requests are done | ||
*/ | ||
getSetDeliveryModeInProcess(): Observable<boolean> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider a different name for this method
Pucek9
previously approved these changes
Dec 10, 2021
Public API changes
|
Pucek9
approved these changes
Dec 21, 2021
sam-garland
added a commit
that referenced
this pull request
Dec 21, 2021
* test: Add tabScreenshot() method for a11y tab e2e testing (#13818) Closes: #13686 * feat: disable shipping method radio input when there is ongoing delivery mode request (#14401) * add spinner when there is onging delivery mode request * disable radio input instead of using spinner * fix regression error: only retrieve enabled radio input * fix broken a18y test * when loading shipping methods, continue button hiden by spinner * remove unused flag * Michal's improvement * fix broken e2e test * fix prettier issue * disable fieldset * add feature level * fix unit test after feature level is introduced * small refactor * remove log * add doc for breaking change * up * fix disable delay issue * remove console.log * add unit test * add space in comment * update migration document * fix build error * remove duplicate spyOn code * use BehaviorSubject to improve test * emit default data in beforeEach Co-authored-by: Michał Gruca <pucek9@gmail.com> Co-authored-by: Caine Rotherham <rotherham.c@gmail.com> Co-authored-by: Jerry Wang <58975336+wangzixi-diablo@users.noreply.github.com> Co-authored-by: Michał Gruca <pucek9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #14386