Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CXSPA-3781 SSR - Multi-provided error interceptors #17865

Merged
merged 10 commits into from
Sep 28, 2023

Conversation

pawelfras
Copy link
Contributor

@pawelfras pawelfras commented Sep 21, 2023

This pull request introduces methodologies for integrating multiple error interceptors that manage errors within the Server-Side Rendering (SSR) framework. This architectural augmentation preserves backward compatibility, mitigating any potential disruptions for end-users upon the incorporation of new error interceptors into the system.

With the introduction of this enhancement, it becomes easier for users to include new error interceptors, giving them the flexibility to determine the order in which these interceptors are applied within the system. This priority setting allows users to control how these interceptors operate and influence the workflow of the system.

The order is:

  1. High priority
  2. Normal or no priority
  3. Low priority

Preserves the original order within a group of interceptors with the same priority.

closes CXSPA-3781

@pawelfras pawelfras marked this pull request as ready for review September 21, 2023 10:49
@pawelfras pawelfras requested a review from a team as a code owner September 21, 2023 10:49
@cla-assistant
Copy link

cla-assistant bot commented Sep 21, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pawelfras
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@cypress
Copy link

cypress bot commented Sep 21, 2023

4 flaky tests on run #41476 ↗︎

0 119 2 0 Flakiness 4

Details:

Merge f2ad20d into ae83fd2...
Project: spartacus Commit: 43f42fd7cc ℹ️
Status: Passed Duration: 08:15 💡
Started: Sep 26, 2023 12:59 PM Ended: Sep 26, 2023 1:08 PM
Flakiness  regression/checkout/checkout-flow.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test Artifacts
Checkout flow > Mobile > should checkout with a registered user Test Replay Output Screenshots Video
Flakiness  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Output Screenshots Video
SSR > should render PLP Test Replay Output Screenshots Video
SSR > should render PDP Test Replay Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions github-actions bot marked this pull request as draft September 22, 2023 11:41
@pawelfras pawelfras marked this pull request as ready for review September 25, 2023 12:21
@github-actions github-actions bot marked this pull request as draft September 25, 2023 12:21
@pawelfras pawelfras marked this pull request as ready for review September 25, 2023 12:33
@github-actions github-actions bot marked this pull request as draft September 25, 2023 12:33
@pawelfras pawelfras marked this pull request as ready for review September 25, 2023 13:29
@pawelfras pawelfras changed the base branch from develop-6.5.x to epic/ssr-error-handling September 26, 2023 09:41
@pawelfras pawelfras requested a review from a team September 26, 2023 09:41
@pawelfras pawelfras requested review from a team as code owners September 26, 2023 09:41
@pawelfras pawelfras changed the base branch from epic/ssr-error-handling to develop-6.5.x September 26, 2023 09:41
@github-actions github-actions bot marked this pull request as draft September 26, 2023 11:13
Platonn
Platonn previously approved these changes Sep 26, 2023
@pawelfras pawelfras marked this pull request as ready for review September 26, 2023 12:45
@pawelfras pawelfras changed the base branch from develop-6.5.x to epic/ssr-error-handling September 27, 2023 08:22
@pawelfras pawelfras merged commit db9157b into epic/ssr-error-handling Sep 28, 2023
7 of 8 checks passed
@pawelfras pawelfras deleted the feature/CXSPA-3781 branch September 28, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants