feat: CXSPA-6575 Introduce MULTI_ERROR_HANDLERS to CxErrorHandler #18662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platonn
reviewed
Mar 22, 2024
core-libs/setup/ssr/error-handling/multi-error-handlers/server-responding-error-handler.ts
Outdated
Show resolved
Hide resolved
Platonn
reviewed
Mar 22, 2024
projects/core/src/error-handling/multi-error-handlers/multi-error-handlers.ts
Outdated
Show resolved
Hide resolved
rmch91
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the MULTI_ERROR_HANDLERS strategy to CxErrorHandler to decide about the destination of caught errors depending on the platform. As part of this PR, only one error handler - LoggingErrorHandler - has been implemented.
QA steps:
pagesproperty indefault-cms-config.ts)npm run dev:ssrcloses CXSPA-6575