refactor: two toggles for strict error handling and server error propagation #18815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platonn
reviewed
May 8, 2024
Comment on lines
32
to
33
| protected isServerErrorPropagationEnabled = | ||
| inject(FeatureToggles).serverErrorPropagation; |
There was a problem hiding this comment.
Let's:
- inject FeatureConfigService as
privateproperty - call it inline .isEnabled() in line 36
(it's not to leave unnecessary properties in public API protected that will need to be removed)
Note: it applies to also other places in this PR
Platonn
reviewed
May 8, 2024
| cachingStrategyResolver: (entry) => !entry.error, | ||
| ssrErrorHandling: true, | ||
| cacheStrategyResolver: (options, entry) => | ||
| !!options.cacheErrors && !!entry.error, |
There was a problem hiding this comment.
- we have to check if
cacheErrorsis expliclity=== true. Becuase otherwise alsoundefinedmakes it falsy by default - and we dont want to toggle it falsy by default. - IMHO semantics of a flag should be falsy when disabled (by default) and truthy when enabled.
What about switching the meaning to avoidCachingErrors. IMHO it's more attactive and understandable for customers to toggle it on. Moreover when it's falsy (false/undefined) => the new behavior is disabled
Platonn
approved these changes
May 9, 2024
Comment on lines
146
to
148
| /** | ||
| * Enable caching of errors. By default, errors are not cached. | ||
| */ |
pawelfras
merged commit f8143ee
into
feat/CXSPA-6939-poc-handling-breaking-changes
4 checks passed
pawelfras
deleted the
feat/CXSPA-6939-toggle-for-sealed-error-handling-and-for-error-propagation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.